Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model: Remove the remaining uses of SortedSet / SortedMap from classes which get serialized #8705

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

model: Remove the remaining uses of SortedSet / SortedMap from classes which get serialized #8705

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3054d38
test(model): Make formatting of `fragments` construction consistent
fviernau May 24, 2024
093f6b6
refactor(model): Use named arguments in a couple of constructor calls
fviernau May 24, 2024
a523522
refactor(model): Stop using `SortedSet` for `scopeRoots`
fviernau May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test(model): Make formatting of fragments construction consistent 
Signed-off-by: Frank Viernau <frank_viernau@epam.com>
  • Loading branch information
@fviernau
fviernau committed Jun 18, 2024
commit 3054d380b46791289d95d775790a0cf36d10ea20
22 changes: 10 additions & 12 deletions model/src/test/kotlin/DependencyGraphTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,11 @@ class DependencyGraphTest : WordSpec({
id("org.apache.commons", "commons-collections4", "4.4"),
id(group = "org.junit", artifact = "junit", version = "5")
)
val fragments =
sortedSetOf(
DependencyReference(0),
DependencyReference(1),
DependencyReference(2)
)
val fragments = sortedSetOf(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message: Probably prefer style over test as the commit type.

DependencyReference(0),
DependencyReference(1),
DependencyReference(2)
)
val scopeMap = mapOf(
"p1:scope1" to listOf(RootDependencyIndex(0), RootDependencyIndex(1)),
"p2:scope2" to listOf(RootDependencyIndex(1), RootDependencyIndex(2))
Expand All @@ -63,12 +62,11 @@ class DependencyGraphTest : WordSpec({
id("org.apache.commons", "commons-collections4", "4.4"),
id("org.junit", "junit", "5")
)
val fragments =
sortedSetOf(
DependencyReference(0),
DependencyReference(1),
DependencyReference(2)
)
val fragments = sortedSetOf(
DependencyReference(0),
DependencyReference(1),
DependencyReference(2)
)
val scopeMap = mapOf(
qualifiedScopeName to listOf(RootDependencyIndex(0), RootDependencyIndex(1)),
DependencyGraph.qualifyScope(qualifier, "scope2") to listOf(
Expand Down