Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put compression backends behind features, clean up Cargo.toml #187

Merged
merged 1 commit into from
Nov 11, 2021
Merged

put compression backends behind features, clean up Cargo.toml #187

merged 1 commit into from
Nov 11, 2021

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Nov 11, 2021

this way it is possible to change compression backends using --no-default-features

Also default zip to deflate-zlib backend since the same feature is already enabled by default in the flate2 dependency

I can add the alignment back if you want to, I just personally think it is better

@SpyrosRoum
Copy link
Contributor

Personally I don't really think this is necessary or needed. The whole point of ouch is to unite all these features, so unless one of them stands out (and has some runtime dependencies, or works differently for example) then I don't see a need for this.
But this is just my opinion of course

@marcospb19
Copy link
Member

marcospb19 commented Nov 11, 2021

But @SpyrosRoum, nothing has really changed, this just adds the capability for people to switch features if they want to. I guess you disagreed because you thought it was changing our defaults?

image

Output of ldd is the same too:

image

(Had to run sed to remove memory address "(0x00007f4cafb1b000)" parts cause branches differ a bit).

@SpyrosRoum
Copy link
Contributor

I know in practice it doesn't really make a difference, I don't have a strong opinion on this either way

@marcospb19
Copy link
Member

I mean, I agree it's not really necessary 🤔 , but I don't plan on adding this to our CI anyway, if someone want to compile with different features, they'll be on their own, so we won't have any additional trouble.

It also unlikely that people will be using this, but because I see no downsides, I'll be merging.

@marcospb19 marcospb19 merged commit d1de343 into ouch-org:master Nov 11, 2021
@figsoda figsoda deleted the deps branch November 11, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants