Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement accessibility mode #197

Merged
merged 5 commits into from
Nov 25, 2021
Merged

Conversation

AntonHermann
Copy link
Contributor

Fixes #194

This is my take at implementing an accessible command line interface.

When either setting the environment variable ACCESSIBLE (to an arbitrary value) or passing the CLI flag --accessible/-A, execute in accessibility mode: reduce visual noise and unnecessary output (almost all info!() calls)

When setting the environment variable ACCESSIBLE to a nonempty value when executing install.sh, suppress noisy output of curl/wget

If environment variable ACCESSIBLE is set to a nonempty value, suppress
output of `curl` or `wget`
Cargo.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
install.sh Show resolved Hide resolved
src/list.rs Outdated Show resolved Hide resolved
@AntonHermann
Copy link
Contributor Author

Sorry about the long delay, I've been pretty busy recently.

This PR contains a fixup commit now which doesn't add any value of its own and there is a small conflict with master. How do you want to handle this?

I could create a merge commit, but I think squashing and rebasing all commits onto master would be cleaner. I would await another review and then squash, rebase and force-push this PR? This way we only have a single, significant commit being merged into master.

src/macros.rs Outdated Show resolved Hide resolved
@marcospb19
Copy link
Member

marcospb19 commented Nov 22, 2021

I could create a merge commit, but I think squashing and rebasing all commits onto master would be cleaner.

Whatever you'd prefer! So far, I did not spent much time on making git history clear, I know it's good, but sometimes I think that we are just low on time, and should pick the "less effort" alternative.

About the conflicts here, I'll solve them once the PR is ready, do not worry.

EDIT: no worries for the delay too, we really appreciate the contribution.

@AntonHermann
Copy link
Contributor Author

Okay great.
I'd like to clear up my doubts about #197 (comment), then I will clean up the PR :)

src/error.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ouch accessible
2 participants