Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: don't allocate when possible in to_utf, nice_directory_display #249

Merged
merged 1 commit into from
Feb 5, 2022
Merged

feat: don't allocate when possible in to_utf, nice_directory_display #249

merged 1 commit into from
Feb 5, 2022

Conversation

vrmiguel
Copy link
Member

@vrmiguel vrmiguel commented Feb 3, 2022

Paths are overwhelmingly more likely to be valid UTF-8 rather than not, so using Cow here is likely very beneficial

marcospb19
marcospb19 approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@marcospb19 marcospb19 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! (run clippy and merge :D)

@vrmiguel vrmiguel merged commit 8b1cd18 into master Feb 5, 2022
@marcospb19 marcospb19 deleted the some-branch branch August 12, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcospb19 marcospb19 marcospb19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vrmiguel @marcospb19