fix(client): Prevent weapon disarm if weapon is currently being used #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you can unlimitedly use ammo by unequipping the weapon you are using while shooting with it.
This PR solves this bug by preventing weapons from being unequipped while they are actively being used (aka weapon timer exists, and is bigger than 0).
Here is a demonstration video: https://streamable.com/oeoqjz
This "fix" would still not cover a case where the weapon is actively used and a "disarm" is called from elsewhere, but I guess that's a very rare edge case which should be handled by the calling script.