forked from pingcap/br
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add unit tests for kv/importer and restore/checkpoints, plus some bug…
… fixes (pingcap#191) * kv: add unit test for importer (based on a mocked gRPC client) * restore: remove the unnecessary SHOW CREATE TABLE calls We can now reconstruct the table info directly from the HTTP reply, so the SHOW CREATE TABLE results are now useless. Better drop them. * restore: add unit test for tidb.go * common: ensure sqlmock errors are not retryable * restore: fix error where checkpoint status of index engine is not updated Also, made the WholeTableEngineID constant public. * restore: rename a confusing variable * restore: fix bug where --checkpoint-error-destroy=all skips index engine * restore: prevent NPE when getting missing table from file checkpoint * restore: add unit tests for checkpoints * kv: address importer comments * kv: also exposes the mock Importer constructor to other tests
- Loading branch information
Showing
16 changed files
with
1,993 additions
and
78 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.