[8.2] Test plan encrypt all and decrypt all #6

DeepDiver1975 · 2015-09-15T14:12:06Z

8.2 introduces occ commands to encrypt and decrypt all files for all users.

this has to be tested and verified with

[ ❌ ] ldap with more than 1 million users ([8.2] Test plan encrypt all and decrypt all #6 (comment))
[ ⛔ ] users with a hell of files and folders (depth 1024 and in total 100.000 files ???) (Not able to have such deep folder structure [8.2] Test plan encrypt all and decrypt all #6 (comment))

@SergioBertolinSG adds:
[ 🕓 ] Encrypt all having only 1 user with 100.000 files of 1KiB. (It takes long time, perhaps three days or so which leads us again to owncloud/core#19358 )

schiessle · 2015-09-15T14:15:45Z

Let me add some points:

[ ✅ ] only decrypt for a specific user
[ ✅ ] run the script multiple times and check that it doesn't break files ([8.2] Test plan encrypt all and decrypt all #6 (comment)) (retested with master 2015-09-25)
[ ✅ ] run with multiple users, where some user have a recovery key and some don't have one (encrypt-all [8.2] Test plan encrypt all and decrypt all #6 (comment)) (retested with master 2015-09-25)
[ ✅ ] run with multiple users some has encrypted files and some has already decrypted files (were blocked by Running occ encryption:decrypt-all without a username doesn't stop and warn the user. core#19327)

@SergioBertolinSG adds:

[ ✅ ] Encrypt all for 1000 LDAP users.
[ ✅ ] Decrypt all users having some recovery key enabled and others don't. ([8.2] Test plan encrypt all and decrypt all #6 (comment)) (retested with master 25-09-2015)

schiessle · 2015-09-15T14:17:59Z

Btw, known limitation. We only decrypt the payload (files in data/user/files). files in trashbin and versions are not decrypted but this shouldn't be an issue as long as the admin keep the encryption modules enabled.

Alternatively he could use the occ script to clean up the trashbins and versions

SergioBertolinSG · 2015-09-18T12:36:01Z

At the end of the encryption when listing the users with passwords, ldap users show the uid, not the username. I think it could be a bit confusing.

+--------------------------------------+----------------------+
| Username                             | Private key password |
+--------------------------------------+----------------------+
| admin                                | wR+emn7r             |
| b8ddc6ea-8742-1034-8cb0-39af73a96b9a | 6rcFnp+g             |
| b8dee17e-8742-1034-8cb3-39af73a96b9a | Fw2onCBX             |
| b8df1298-8742-1034-8cb4-39af73a96b9a | AeTC6Mib             |
| b8df517c-8742-1034-8cb5-39af73a96b9a | A5CQeXoS             |

SergioBertolinSG · 2015-09-21T09:11:11Z

@schiesbn How can I decrypt only for one user?
encryption:decrypt-all seems to decrypt everything.

SergioBertolinSG · 2015-09-21T09:18:42Z

When encrypting everything only admin user can login.

It says owncloud is in a single user mode.

Opened issue here owncloud/core#19213

schiessle · 2015-09-21T10:49:47Z

At the end of the encryption when listing the users with passwords, ldap users show the uid, not the username. I think it could be a bit confusing.

I think the problem is that LDAP users can even have multiple login names, so I don't really know what to show here... @blizzz any idea what we can/should show instead for ldap users?

We could show the display name instead of the uid. But the display name is not guaranteed to be unique.

schiessle · 2015-09-21T10:52:11Z

How can I decrypt only for one user?

you can call decrypt-all with a user-id as parameter, see:

$ ./occ encryption:decrypt-all --help
Usage:
 encryption:decrypt-all [user]

Arguments:
 user                  user for which you want to decrypt all files (optional)

(same "problem" as above, for LDAP users you need the ID)

SergioBertolinSG · 2015-09-21T11:17:51Z

After decrypting only one user's files, it has disabled encryption app.

sudo -u www-data ./occ encryption:status
  - enabled: false
  - defaultModule: OC_DEFAULT_MODULE

Also when asking for login password, it is a single user but it writes 'users' in plural.

Please enter the users login password:

ghost · 2015-09-21T11:27:38Z

It's not plural, it's missing the apostrophe in user's

schiessle · 2015-09-21T11:34:18Z

After decrypting only one user's files, it has disabled encryption app.

That's the intended behavior. The idea is that if you want to decrypt all you also want to disable encryption, see the description:

This will disable server-side encryption and decrypt all files for all users if it is supported by your encryption module. Please make sure that no user access his files during this process!

The main purpose of adding a specific user as parameter is to allow to disable encryption for small instances where you don't have a recovery key but know the users login password or can ask them to enter it. Maybe there is one use case in a enterprise setup, if the decryption failed at some point and you want to call it again for a specific user. But every time it is coupled with the assumption that you want to disable encryption.

schiessle · 2015-09-21T11:36:39Z

@cmonteroluque thanks, typo is fixed here owncloud/core#19223

SergioBertolinSG · 2015-09-21T11:46:52Z

@schiesbn ok, thanks.

After decrypting files for only one user, enabling again encryption and running encrypt-all it returns errors related with locked files:

is it a problem? or it a bad use of encrypt-all ?

 encrypt files for user admin (1 of 3): /admin/files/Photos/Paris.jpg 
 [->--------------------------]


  [OCP\Lock\LockedException]                         
  "Photos/Paris.jpg.encrypted.1442835845" is locked  


  [OCP\Lock\LockedException]                          
  "files/e9be9dd5048c73ae94d6d5759fde6b90" is locked

schiessle · 2015-09-22T08:34:46Z

@SergioBertolinSG I can reproduce it and will look into it. This worked in the past, maybe the way locking works changed recently?

  [OCP\Lock\LockedException]                          
  "files/e9be9dd5048c73ae94d6d5759fde6b90" is locked

also this file is really confusing. Where does it come from? The encrypt all script doesn't create such files... @PVince81 @icewind1991 any idea? Is this something locking specific?

PVince81 · 2015-09-22T08:38:36Z

@schiesbn this is just a hash of the file path, not the real path to the file.

PVince81 · 2015-09-22T08:39:05Z

@SergioBertolinSG please specify the version you are testing, a few days ago a locking issue was fixed on master.

SergioBertolinSG · 2015-09-22T08:40:37Z

Version is beta1 {"installed":true,"maintenance":false,"version":"8.2.0.6","versionstring":"8.2 beta1","edition":"Enterprise"}

schiessle · 2015-09-22T08:50:37Z

I could re-produce it. The copy operation throws an exception (https://github.com/owncloud/core/blob/master/lib/private/files/view.php#L788), so we never release the lock. Everywhere where we create locks we should have a try-catch block to remove the lock correctly if a exception happens. (I will rise a separate issue for it).

Beside that I will try to find out why the exception happens.

schiessle · 2015-09-22T08:55:55Z

Issue regarding the locking problem: owncloud/core#19242

schiessle · 2015-09-22T09:01:55Z

OK, throwing a exception on copy is OK in this case. We try to copy a already encrypted file and because we don't have the user password we don't have his private key -> operation will fail with a exception. This is catched and handled correctly in the encryptAll() script. We just need to make sure that locking frees the file correctly.

schiessle · 2015-09-22T09:34:51Z

@SergioBertolinSG this pr should fix the issue owncloud/core#19247

blizzz · 2015-09-22T09:52:45Z

At the end of the encryption when listing the users with passwords, ldap users show the uid, not the username. I think it could be a bit confusing.

I think the problem is that LDAP users can even have multiple login names, so I don't really know what to show here... @blizzz any idea what we can/should show instead for ldap users?

What is probably supposed to be shown is the owncloud username (as displayed in the very first column on the users page), to clearly identify a user. If however the used login name is being displayed, then it does not identify a user. Could you output the userid instead, @schiesbn?

SergioBertolinSG · 2015-09-22T10:51:05Z

@schiesbn While I find the occ encryption:encrypt-all interface nice for few users few files, I think it is not comfortable for massive set ups.
It has some interactive questions which are not avoidable. And the progress bar might be a problem.
Thinking like a ops person running this command I guess they'd like to use a command like

nohup sudo -u www-data ./occ encryption:encrypt-all  1>&2  | tee nohup.out &

To run the encryption all the night and see the results next day.

Perhaps this suggestion is a huge improvement. What do you think?

schiessle · 2015-09-22T11:00:44Z

@SergioBertolinSG he could also run it in a screen session and look at the output at the next day. As you said we need some interaction, so I don't see how this should work. Also the progress bar was a feature people asked all the time in the past so that they get a feeling how long it will take and see that something happens.

schiessle · 2015-09-22T11:07:40Z

@blizzz The userid is what we display at the moment, see #6 (comment)

@SergioBertolinSG thought that this could be confusing. But I don't know what a typical LDAP admin would expect. As we also use it in the user management I think this is the right ID.

rperezb · 2015-09-22T16:21:59Z

@SergioBertolinSG please, related to encryption, take into account as well: owncloud/core#18482
Also related: https://github.com/owncloud/enterprise/issues/518#issuecomment-142277685

thx

SergioBertolinSG · 2015-09-23T06:42:44Z

@schiesbn @DeepDiver1975 Encrypt-all command having 1 million of ldap users takes too much time (many days).
It also uses 100% cpu all the time.
I think this is a performance problem for huge installations.

schiessle · 2015-09-23T10:49:55Z

@SergioBertolinSG do all 1 million people have files on ownCloud? How many files? What is the size of the files? Would be good to have some additional numbers. Maybe you can also evaluate the different steps. First we create a key pair for each user, how long does this take and when does it starts to encrypt the files?

Generally speaking: It is expensive to encrypt all files for all users. That's why in general "encryption yes/no" should always be a decision by the admin at the beginning. This scripts are only there is someone really, really wants to switch a existing installation and can't live with the default behavior (files get encrypted the next time you touch it). It is nothing which we want the admins to turn it on and off all the time. I don't see how this can be speed up substantially. We need to read every file, encrypt it and write it again. Also 1 million sounds quite academic to me. I think even the largest installations are far away from 1 million users.

But let's look at the numbers and see if we can improve at least some parts. (But I fear that 1 million users, all have a few MB or even GB of data will always take looooong)

SergioBertolinSG · 2015-09-23T11:09:41Z

It takes too much in creating all the key-pair.
Users have only the default files when creating a new account.

Perhaps 1 million is too much, but I don't think encrypting this way is suitable for even 50000 users with very few files for example.

SergioBertolinSG · 2015-09-23T11:25:16Z

After 24h running it has created ~29000 key-pair.

schiessle · 2015-09-23T11:30:05Z

As said, I fear that we can't do much about it.

To illustrate it I wrote this small test script:

$res = openssl_pkey_new();
openssl_pkey_export($res, $privateKey);
$keyDetails = openssl_pkey_get_details($res);
$publicKey = $keyDetails['key'];
openssl_encrypt($privateKey, 'AES-256-CFB', 'password', false, '+ln5iNDghie+imWy');

It just perform the basic openSSL operations to create the key pair and to encrypt it.

This script takes something between 0.055 ans 0.24 seconds if I run it multiple times. For now let's assume that it takes 0.1 seconds in average for every keypair (which is probably to optimistic, but anyway).

For 1 million users this means 1666 minutes ~ 27h (worst case (0.24s/key): 4000 minutes ~ 66h)
For 50.000 users this means 83 minutes (worst case (0.24s/key): 200 minutes)

There is nothing we can do. That's just openssl. In our case we need to write the keys to the hard disc and update the file cache (maybe something we could defer). But we would always have 50 minutes + writing 100.000 files to the disc (private/public key for 50.000 users).

schiessle · 2015-09-23T11:37:16Z

Just to get a idea how much time we could save by disabling the file cache update for each key.

Can you try to edit lib/private/encryption/keys/storage.php and add here https://github.com/owncloud/core/blob/master/lib/private/encryption/keys/storage.php#L64

this line:

$this->view->getUpdater()->disable();

And then run the test again with 50.000 user. This way all keys should be created in about 200 minutes (worst case from above) + the time needed to write the keys to the hard disc, so the absolute minimum if the file cache is disabled.

This is just a dirty hack to disable the cache and see if it would help at all. That's the only thing I see which could be improved.

SergioBertolinSG · 2015-09-23T15:53:45Z

Regarding the deep folder structure I found this owncloud/core#19309

SergioBertolinSG · 2015-09-23T16:11:00Z

@schiesbn I've retested #6 (comment) with last master (2015-09-23) and I an facing the same locking errors.

Shall we reopen thttps://github.com/owncloud/core/issues/19242 ?

SergioBertolinSG · 2015-09-23T16:38:23Z

Using decrypt-all without a parameter it doesn't fail hard. This is a bug.
EDIT : opened here owncloud/core#19327

User "" does not exist. Please check the username and try again
 aborted.

SergioBertolinSG · 2015-09-23T16:46:31Z

Trying to encrypt all files when some users have the recovery key enabled it has raised the locking error as well.

 encrypt files for user user0 (2 of 101): /user0/files/Photos/Paris.jpg         
 [----->----------------------]                                                 


  [OCP\Lock\LockedException]                         
  "Photos/Paris.jpg.encrypted.1443026602" is locked  






  [OCP\Lock\LockedException]                          
  "files/d24647e6e789451593e32698e351c4bc" is locked

SergioBertolinSG · 2015-09-24T08:26:45Z

@schiesbn this test "run with multiple users some has encrypted files and some has already decrypted files" means that decrypt-all should work also for all users without putting a parameter as username?

SergioBertolinSG · 2015-09-24T08:50:01Z

Using encrypt-all when key-pair where created already returns an output not prepared for this case owncloud/core#19332

schiessle · 2015-09-24T10:02:59Z

@schiesbn this test "run with multiple users some has encrypted files and some has already decrypted files" means that decrypt-all should work also for all users without putting a parameter as username?

Yes, in this case the script should just decrypt the files from the remaining users so that at the end the files for all users are decrypted

SergioBertolinSG · 2015-09-24T10:49:13Z

Running the decryption to all users while some has recovery key enabled and some don't using patch from owncloud/core#19340) oC keeps in single-user mode.
(master from 2015-09-24 + patch)

Besides that and disabling single-user mode manually it works correctly. Only users with recovery key has their files decrypted while the rest remain encrypted.

schiessle · 2015-09-24T10:50:25Z

did you saw any error message in your terminal or apache/owncloud log?

From the code path I don't see how this could happen. Either you reach the end and we disable single user mode or we disable it in the catch-block

schiessle · 2015-09-24T10:57:42Z

Trying to encrypt all files when some users have the recovery key enabled it has raised the locking error as well.

I can't re-produce it. Can you explain the step to reproduce it (please keep the example as small as possible, as few users, files and settings as possible to isolate the problem)

SergioBertolinSG · 2015-09-24T10:59:29Z

did you saw any error message in your terminal or apache/owncloud log?

No errors in the terminal.
In logs only some repetead info

{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"stream_wrapper_register(): Protocol ocencryption:\/\/ is already defined. at \/opt\/owncloud\/lib\/private\/files\/stream\/encryption.php#187","level":3,"time":"2015-09-24T10:40:10+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#502","level":3,"time":"2015-09-24T10:40:10+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#503","level":3,"time":"2015-09-24T10:40:10+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"stream_wrapper_register(): Protocol ocencryption:\/\/ is already defined. at \/opt\/owncloud\/lib\/private\/files\/stream\/encryption.php#187","level":3,"time":"2015-09-24T10:40:10+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#502","level":3,"time":"2015-09-24T10:40:10+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#503","level":3,"time":"2015-09-24T10:40:10+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"stream_wrapper_register(): Protocol ocencryption:\/\/ is already defined. at \/opt\/owncloud\/lib\/private\/files\/stream\/encryption.php#187","level":3,"time":"2015-09-24T10:40:10+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#502","level":3,"time":"2015-09-24T10:40:10+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#503","level":3,"time":"2015-09-24T10:40:10+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"stream_wrapper_register(): Protocol ocencryption:\/\/ is already defined. at \/opt\/owncloud\/lib\/private\/files\/stream\/encryption.php#187","level":3,"time":"2015-09-24T10:40:10+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#502","level":3,"time":"2015-09-24T10:40:10+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#503","level":3,"time":"2015-09-24T10:40:10+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"stream_wrapper_register(): Protocol ocencryption:\/\/ is already defined. at \/opt\/owncloud\/lib\/private\/files\/stream\/encryption.php#187","level":3,"time":"2015-09-24T10:40:10+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#502","level":3,"time":"2015-09-24T10:40:10+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#503","level":3,"time":"2015-09-24T10:40:10+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"stream_wrapper_register(): Protocol ocencryption:\/\/ is already defined. at \/opt\/owncloud\/lib\/private\/files\/stream\/encryption.php#187","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#502","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#503","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"stream_wrapper_register(): Protocol ocencryption:\/\/ is already defined. at \/opt\/owncloud\/lib\/private\/files\/stream\/encryption.php#187","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#502","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#503","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"stream_wrapper_register(): Protocol ocencryption:\/\/ is already defined. at \/opt\/owncloud\/lib\/private\/files\/stream\/encryption.php#187","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#502","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#503","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"stream_wrapper_register(): Protocol ocencryption:\/\/ is already defined. at \/opt\/owncloud\/lib\/private\/files\/stream\/encryption.php#187","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#502","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#503","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"stream_wrapper_register(): Protocol ocencryption:\/\/ is already defined. at \/opt\/owncloud\/lib\/private\/files\/stream\/encryption.php#187","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#502","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#503","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"stream_wrapper_register(): Protocol ocencryption:\/\/ is already defined. at \/opt\/owncloud\/lib\/private\/files\/stream\/encryption.php#187","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#502","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#503","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"stream_wrapper_register(): Protocol ocencryption:\/\/ is already defined. at \/opt\/owncloud\/lib\/private\/files\/stream\/encryption.php#187","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#502","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#503","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"stream_wrapper_register(): Protocol ocencryption:\/\/ is already defined. at \/opt\/owncloud\/lib\/private\/files\/stream\/encryption.php#187","level":3,"time":"2015-09-24T10:40:11+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#502","level":3,"time":"2015-09-24T10:40:12+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"fclose() expects parameter 1 to be resource, string given at \/opt\/owncloud\/lib\/private\/files\/storage\/wrapper\/encryption.php#503","level":3,"time":"2015-09-24T10:40:12+00:00"}
{"reqId":"YjAGG04JbJgK70van84C","remoteAddr":"","app":"PHP","message":"stream_wrapper_register(): Protocol ocencryption:\/\/ is already defined. at \/opt\/owncloud\/lib\/private\/files\/stream\/encryption.php#187","level":3,"time":"2015-09-24T10:40:12+00:00"}

SergioBertolinSG · 2015-09-24T12:00:33Z

I can't re-produce it. Can you explain the step to reproduce it (please keep the example as small as possible, as few users, files and settings as possible to isolate the problem)

OK, the problem happens only when decrypting-all and later encrypting-all again. So the problem is the same as with #6 (comment)

schiessle · 2015-09-24T13:08:44Z

OK, the problem is only when decrypting-all and later encrypting-all again. So the problem is the same as with #6 (comment)

still can't re-produce it. Works as expected on my system (master d7a923671fa4b10f74dc615b583f6d4f5935d45b)

schiessle · 2015-09-25T08:15:26Z

No errors in the terminal.
In logs only some repetead info

hm, looks OK. The warnings shouldn't be a problem, though I will add a if statement to avoid the warning. Still don't see how you can neither reach the end nor the catch block to execute one of the two $this->resetSingleUserAndTrashbin(); method calls after single user mode was activated (https://github.com/owncloud/core/blob/master/core/command/encryption/encryptall.php#L117):

$this->forceSingleUserAndTrashbin();
try {
    $defaultModule = $this->encryptionManager->getEncryptionModule();
    $defaultModule->encryptAll($input, $output);
} catch (\Exception $ex) {
    $this->resetSingleUserAndTrashbin();
    throw $ex;
}
$this->resetSingleUserAndTrashbin();

rperezb assigned SergioBertolinSG Sep 17, 2015

rperezb added this to the 8.2 milestone Sep 22, 2015

SergioBertolinSG closed this as completed Apr 13, 2016

[8.2] Test plan encrypt all and decrypt all #6

[8.2] Test plan encrypt all and decrypt all #6

Comments

DeepDiver1975 commented Sep 15, 2015

schiessle commented Sep 15, 2015

schiessle commented Sep 15, 2015

SergioBertolinSG commented Sep 18, 2015

SergioBertolinSG commented Sep 21, 2015

SergioBertolinSG commented Sep 21, 2015

schiessle commented Sep 21, 2015

schiessle commented Sep 21, 2015

SergioBertolinSG commented Sep 21, 2015

ghost commented Sep 21, 2015

schiessle commented Sep 21, 2015

schiessle commented Sep 21, 2015

SergioBertolinSG commented Sep 21, 2015

schiessle commented Sep 22, 2015

PVince81 commented Sep 22, 2015

PVince81 commented Sep 22, 2015

SergioBertolinSG commented Sep 22, 2015

schiessle commented Sep 22, 2015

schiessle commented Sep 22, 2015

schiessle commented Sep 22, 2015

schiessle commented Sep 22, 2015

blizzz commented Sep 22, 2015

SergioBertolinSG commented Sep 22, 2015

schiessle commented Sep 22, 2015

schiessle commented Sep 22, 2015

rperezb commented Sep 22, 2015

SergioBertolinSG commented Sep 23, 2015

schiessle commented Sep 23, 2015

SergioBertolinSG commented Sep 23, 2015

SergioBertolinSG commented Sep 23, 2015

schiessle commented Sep 23, 2015

schiessle commented Sep 23, 2015

SergioBertolinSG commented Sep 23, 2015

SergioBertolinSG commented Sep 23, 2015

SergioBertolinSG commented Sep 23, 2015

SergioBertolinSG commented Sep 23, 2015

SergioBertolinSG commented Sep 24, 2015

SergioBertolinSG commented Sep 24, 2015

schiessle commented Sep 24, 2015

SergioBertolinSG commented Sep 24, 2015

schiessle commented Sep 24, 2015

schiessle commented Sep 24, 2015

SergioBertolinSG commented Sep 24, 2015

SergioBertolinSG commented Sep 24, 2015

schiessle commented Sep 24, 2015

schiessle commented Sep 25, 2015