Acceptance tests for renaming and moving activities

[JammingBen]

#1018 and owncloud/core#39430 introduce activities for rename- and move-actions. The following scenarios need acceptance test scenarios:

• Rename file in root
• Rename file in a subfolder
• Move file into subfolder
• Move folder out of subfolder
• Rename a shared folder -> only affects the user who renames
• Rename a file inside a shared folder -> affects all share users (**)
• Move a file inside a shared folder into a subfolder inside the share -> affects all share users (**)
• Move a file into the share -> affects all share users, but only the users who moves sees the source path (**)
• Move a file out of a share -> affects all share users, but only the users who moves sees the destination path (**)

** also use "Shares" as default share folder

@phil-davis Could you and your team have a look at this?

[phil-davis]

Could you and your team have a look at this?

yes, I added it to our project board.

To whoever gets assigned: most of this should be able to be done efficiently with API tests. Just make a couple of webUI scenarios that verify that the rename and move activity entries do get displayed on the webUI.

[kiranparajuli589]

@JammingBen @phil-davis the feature PRs seems not merged yet. should we write tests in the feature branch...or do a PR in for the feature branch?

[phil-davis]

@JammingBen @phil-davis the feature PRs seems not merged yet. should we write tests in the feature branch...or do a PR in for the feature branch?

Checkout the PR branch and then branch off that and make tests in another branch in the activity app.

Note: the CI needs to also point to the core branch that provides support for this, until the core PR is merged.

[kiranparajuli589]

• TODO: see [tests-only] [full-ci] Added acceptance tests for move and rename activities #1022 (comment)

[phil-davis]

@kiranparajuli589 Last week I added a couple of scenarios for moving a file between shares (shares to users, and shares to groups).

Can you think of any other interesting test cases?

[kiranparajuli589]

TODO:

• check a public user action
• webui scenarios

[phil-davis]

@kiranparajuli589 the code PR has been merged, so you can branch from latest master to add more test scenarios.

[individual-it]

#1030 was merged, more tests needed?

[phil-davis]

We could just have 2 scenarios for an ordinary rename and move. (The actual rename and move can be done with the API or whatever is easiest) And demonstrate that the UI shows the activity entries with the expected rename/move words.

This can easily be reassigned to someone to finish while @kiranparajuli589 is on leave.

[phil-davis]

This should not be too difficult. @sushmita56 please add rename and move scenarios, then this issue can be closed.

[sushmita56]

@phil-davis The Activity tab on the UI doesn't show any notification regarding the moving/copying of the resource but it shows the information about the resource creation/deletion. Is this an expected behavior or should I report an issue?

[phil-davis]

@sushmita56 the feature has to be enabled:

php occ config:app:set activity enable_move_and_rename_activities --value yes

Then it works.

In Gherkin feature files hace a Given step like:

Given the administrator has added config key "enable_move_and_rename_activities" with value "yes" in app "activity"

[SwikritiT]

@phil-davis the PR for web-ui test #1109 has been merged. I guess it's safe to close this? Or do we need to add more tests?

[phil-davis]

done - closing