Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added scenario to check activity from public user #1030

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Added scenario to check activity from public user #1030

merged 2 commits into from
Nov 22, 2021

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Nov 12, 2021 •
edited
Loading

Description

Add bug demonstration scenario for #1032

Part of #1019 See #1019 (comment)

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiActivity-master-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/activity/2314/25/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiActivity-master-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/activity/2319/3/1

@kiranparajuli589 kiranparajuli589 mentioned this pull request Nov 16, 2021
Open
@kiranparajuli589 kiranparajuli589 self-assigned this Nov 16, 2021
@kiranparajuli589
Copy link
Contributor Author

blocked because activity is not listed for rename using /core/remote.php/webdav/parent/textfile.txt HTTP/1.1

@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review November 17, 2021 09:06
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiActivity-master-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/activity/2326/25/1

@individual-it
Copy link
Member

@phil-davis @kiranparajuli589 should we have bug-demo tests for this?

@kiranparajuli589
Copy link
Contributor Author

@phil-davis @kiranparajuli589 should we have bug-demo tests for this?

@individual-it I've refactored the code to include a bug demonstration scenario.

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@individual-it
Copy link
Member

rebased on master

@sonarcloud
Copy link

sonarcloud bot commented Nov 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@individual-it individual-it merged commit b83c4f0 into master Nov 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the public-rename-action branch November 22, 2021 06:16
@individual-it individual-it mentioned this pull request Nov 22, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@swoichha swoichha Awaiting requested review from swoichha

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kiranparajuli589 @ownclouders @individual-it @CLAassistant @phil-davis