Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't skip uploads when checksum is unchanged #4754

Closed
ckamm opened this issue Apr 28, 2016 · 1 comment
Closed

Don't skip uploads when checksum is unchanged #4754

ckamm opened this issue Apr 28, 2016 · 1 comment
Assignees
@ckamm
Milestone
2.2.0

Comments

@ckamm
Copy link
Contributor

ckamm commented Apr 28, 2016 •
edited
Loading

We enabled content checksum based upload skipping in #4375. Now we're concened that not updating mtimes on the server might break some customer use cases.

We want to revert the behavior to apply the "skip upload" workaround only for *.eml files, as before.

There'll be a different ticket to move this forward again (by including a PROPSET that updates the server mtime and possibly skipping unnecessary downloads if only the metadata changed).
@ckamm ckamm self-assigned this Apr 28, 2016
@ckamm ckamm added this to the 2.2.0-current milestone Apr 28, 2016
@ckamm ckamm mentioned this issue Apr 28, 2016
Open
ckamm added a commit to ckamm/owncloud-client that referenced this issue Apr 28, 2016
@ckamm
Checksums: Skip uploads of .eml files only owncloud#4754
9739764 
This is a workaround. A correct solution would still update file metadata
such as the mtime. See owncloud#4755.
ckamm added a commit that referenced this issue Apr 28, 2016
@ckamm
Checksums: Skip uploads of .eml files only #4754
68126dc 
This is a workaround. A correct solution would still update file metadata
such as the mtime. See #4755.
@ckamm ckamm added the ReadyToTest QA, please validate the fix/enhancement label Apr 28, 2016
@mcastroSG
Copy link

Works fine, just for eml files downloads are skipped.

Tests

@mcastroSG mcastroSG removed the ReadyToTest QA, please validate the fix/enhancement label May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckamm ckamm

Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
2 participants
@ckamm @mcastroSG