Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] VFS on Win10 is not "recommended" setting in connection wizard #8317

Closed
jnweiger opened this issue Dec 21, 2020 · 6 comments
Closed

[QA] VFS on Win10 is not "recommended" setting in connection wizard #8317

jnweiger opened this issue Dec 21, 2020 · 6 comments

Comments

@jnweiger
Copy link
Contributor

Test on Win10 Pro 20H2
https://download.owncloud.com/desktop/ownCloud/testing/2.7.4-rc1.2909/win/ownCloud-2.7.4-rc1.2909.x64.msi

  • start client
  • connect to demo.owncloud.org
  • the connection wizards shows several options:

image

  • The first option (VFS) is default selected. OK
  • But the second option "syncthonize everything" says "(recommended)". BAD

Expected behaviour: the default selection is "(recommended)".

@TheOneRing
Copy link
Member

Good point, I stopped reading those strings a loooong time ago.

@jnweiger
Copy link
Contributor Author

jnweiger commented Dec 21, 2020

Suggest to also rephrase the second option to say
"Synchronize immediately" instead of "Synchronize everything"

"Everything" was always wrong, because only this option allows selective sync, "Choose what to sync"
(The VFS always exposes the the entire tree, no selective sync is available, that is what I'd call "Everything" ...)

@michaelstingl
Copy link
Contributor

"Synchronize immediately"

Also wrong because of initial discovery will need some time with bigger accounts.

@jnweiger jnweiger mentioned this issue Dec 21, 2020
63 tasks
@jnweiger
Copy link
Contributor Author

"Synchronize immediately"

Also wrong because of initial discovery will need some time with bigger accounts.

"There is no such thing as immediate" -- I know :-)

The discovery time is the same overhead, with or without VFS. That also can take long with VFS.
(Possibly even longer, as selective sync cannot be used to skip the unimportant. )

TheOneRing added a commit that referenced this issue Jan 12, 2021
TheOneRing added a commit that referenced this issue Jan 12, 2021
@TheOneRing
Copy link
Member

Fixed in https://github.com/owncloud/client/pull/8348/files
The fix will only go to master as we don't want to break the translations.

@jnweiger
Copy link
Contributor Author

"Synchronize immediately"

Also wrong because of initial discovery will need some time with bigger accounts.

This argument is moot. We advertise VFS as the opposite of immediate so we can identify the opposite of vfs as immediate. (Just in case we want to make things self explanatory through logic)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants