Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change note to warning in documentation #4605

Merged
merged 1 commit into from Apr 7, 2016
Merged

Change note to warning in documentation #4605

merged 1 commit into from Apr 7, 2016

Conversation

ghost
Copy link

@ghost ghost commented Mar 23, 2016

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @danimo, @dragotin and @carlaschroder to be potential reviewers

@ghost
Copy link
Author

ghost commented Mar 24, 2016

@RealRancor

Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@dragotin
Copy link
Contributor

@carlaschroder your call, please.

@guruz
Copy link
Contributor

guruz commented Mar 30, 2016

@icewind1991 Can you help us with this one?

I wonder if the (original part) is actually true... or shall we mention that the original part is especially valid if filesystem_check_changes is 0?

@ghost
Copy link
Author

ghost commented Mar 30, 2016

@guruz The original part is there since ages and long before filesystem_check_changes was set to 0 as the default. So a clarification definitely makes sense.

@guruz
Copy link
Contributor

guruz commented Mar 30, 2016

                                                                                  Would you like to add the occ scan command or a link to it? Like "if you modified, you need to run..." or so?                                                                                                                                                                                                                                                                                                                                        

@guruz guruz added this to the 2.2.0-current milestone Apr 7, 2016
@guruz guruz merged commit c64720e into owncloud:master Apr 7, 2016
@ghost
Copy link
Author

ghost commented Apr 7, 2016

Thanks for merging. I think this is getting even more important as discussed here: owncloud/core#23783

@guruz
Copy link
Contributor

guruz commented Apr 7, 2016

oh well.. :-|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants