-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve windows update downloader #9153
Conversation
60ca9cb
to
09f0416
Compare
Kudos, SonarCloud Quality Gate passed! |
09f0416
to
57484ad
Compare
Kudos, SonarCloud Quality Gate passed! |
setDownloadState(DownloadComplete); | ||
} else { | ||
QNetworkReply *reply = qnam()->get(QNetworkRequest(QUrl(url))); | ||
auto request = QNetworkRequest(QUrl(url)); | ||
request.setAttribute(QNetworkRequest::RedirectPolicyAttribute, QNetworkRequest::NoLessSafeRedirectPolicy); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be the default everywhere nowadays?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default are manual redirects, with the flag I enable redirects and don't limit them.
I guess I should implement a fake server and not rely on our mirror....
Fixes: #7390