Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Link to specific contact #318

Closed
aspdye opened this issue Mar 30, 2016 · 9 comments
Closed

[Enhancement] Link to specific contact #318

aspdye opened this issue Mar 30, 2016 · 9 comments
Assignees
Labels
Milestone

Comments

@aspdye
Copy link
Contributor

aspdye commented Mar 30, 2016

Give Apps (like Calendar) the possibility to link e.g. Birthday Events to specific contacts

owncloud/calendar#383

cc @DeepDiver1975 @Henni @georgehrke @skjnldsv

@skjnldsv
Copy link
Contributor

I'm planning on fixing #312, which means modifying the base url loading.
So I should allow the direct uid link and fix the contact load :)

@Henni
Copy link
Contributor

Henni commented Mar 30, 2016

It should be possible via:
http://localhost:8080/index.php/apps/contacts/#/All%20contacts/87119bde-04fd-4926-aa84-21ddd88de7ea
But there is currently a bug which discards the uid and instead opens the first contact.

@DeepDiver1975 maybe we should remove the localization from the URL to allow generic links from outside the app.

@Henni Henni added the bug label Mar 30, 2016
@Henni Henni added this to the 1.2 milestone Mar 30, 2016
@skjnldsv
Copy link
Contributor

@Henni Yep, we should allow direct uid access without group.
I don't think the localization would be a problem, we could do like that:

  • group & uid set and uid in group -> display contact
  • uid set -> display All contact group + contact
  • group set -> display group and first contact
  • group & uid set but uid not in group -> change to the correct group and display contact
  • group & uid set but uid unknown -> display message saying that the contact is unknown

@Henni
Copy link
Contributor

Henni commented Mar 30, 2016

i think we should always have a group.
If you don't want a specific group you should set it to 'all'
So the path should look like:
/apps/contacts/#/all/87119bde-04fd-4926-aa84-21ddd88de7ea

@DeepDiver1975
Copy link
Member

The uid is not enough the address book is has to be encoded in there as well - remember we want to build the app to load data as lazy as possible.

@DeepDiver1975
Copy link
Member

In other words: the group has no meaning in this case.

@skjnldsv skjnldsv self-assigned this Mar 31, 2016
skjnldsv added a commit that referenced this issue Mar 31, 2016
Fixed direct link to contact and invalid contact access in group (fix #318)
@skjnldsv
Copy link
Contributor

Should be fixed in #323 !
Please review.

Url will be https://localhost/index.php/apps/contacts/#/all/2cbf6908-4a5b-403f-8e68-77165679b3bb for a direct access to a contact

skjnldsv added a commit that referenced this issue Mar 31, 2016
Fixed direct link to contact and invalid contact access in group (fix #318)
Fixed page loading with invalid group
skjnldsv added a commit that referenced this issue Mar 31, 2016
Fixed direct link to contact and invalid contact access in group (fix #318)
Fixed page loading with invalid group
@DeepDiver1975
Copy link
Member

Url will be https://localhost/index.php/apps/contacts/#/all/2cbf6908-4a5b-403f-8e68-77165679b3bb for a direct access to a contact

This will not work once we have a different model in terms of loading contacts - see #318 (comment)

@skjnldsv
Copy link
Contributor

We will edit the code when necessary then no?
Or will those change be in the 1.2?

Can you take a look at the PR?

skjnldsv added a commit that referenced this issue Apr 3, 2016
Fixed direct link to contact and invalid contact access in group (fix #318)
Fixed page loading with invalid group
Fix mobile merge and group contact load issue
skjnldsv added a commit that referenced this issue Apr 5, 2016
Fixed direct link to contact and invalid contact access in group (fix #318)
Fixed page loading with invalid group
Fix mobile merge and group contact load issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants