Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error loading page when no contacts #347

Merged
merged 1 commit into from
Apr 10, 2016

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Apr 7, 2016

Did a mistake with the new loading fix (ref #323)
When you don't have any contacts, loading the page generate an error and doesn't load further.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @Henni, @DeepDiver1975 and @irgendwie to be potential reviewers

@codecov-io
Copy link

Current coverage is 10.91%

Merging #347 into master will not affect coverage as of e01603c

@@            master    #347   diff @@
======================================
  Files           41      41       
  Stmts          751     751       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit             82      82       
  Partial          0       0       
  Missed         669     669       

Review entire Coverage Diff as of e01603c


Uncovered Suggestions

  1. +2.13% via ...ntactColor_filter.js#3...18
  2. +2.00% via ...dressBook_service.js#148...162
  3. +1.60% via ...ntactColor_filter.js#23...34
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@DeepDiver1975
Copy link
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit afa5457 into master Apr 10, 2016
@DeepDiver1975 DeepDiver1975 deleted the fix-no-contacts-loading branch April 10, 2016 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants