-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
While opening or searching for users within admin user listing, all groups are fetched #29382
Comments
@felixheidecke is it possible to keep section with group listing fixed or at least paged (e.g. displaying first 10) ? For now with each refresh of /user/users we execute this line https://github.com/owncloud/core/blob/master/settings/users.php#L68-L68. |
I actually achieved that by with first refresh, just leaving code unchanged. Before I started searching, I just commented out lines 68, 110, 112, 115 in https://github.com/owncloud/core/blob/master/settings/users.php Then I searched for users, and the group pannel was untouched, and no data was fetched from DB. for groups. @felixheidecke @PVince81 other thing will be to have the group section paged + independent from user search. |
@DeepDiver1975 for now it might sound trivial, but with central group table(#29107), it will not anymore go to LDAP, it will go to database and become immediately visible for sysadmins. With LDAP it was a bit hidden probably, since it was not hitting DB. |
Possibly related and overdue: #9201 and loading groups with XHR/ajax |
Hey, this issue has been closed because the label (This is an automated comment from GitMate.io.) |
Hey, this issue has been closed because the label (This is an automated comment from GitMate.io.) |
This issue has been automatically closed. |
I have noticed, that with any operation done within user listing, e.g.
we are fetching not only all the groups in the system, but also, sequentialy, for each of them fetching their metadata (https://github.com/owncloud/core/blob/master/lib/private/Group/MetaData.php#L90-L90 with https://github.com/owncloud/core/blob/master/settings/Controller/GroupsController.php#L88-L88).
This means, that having 50k groups, with each manipulation in the user interface, we will first fetch 50k groups from table, and then for each of 50k groups we will count number of users in that group.
@DeepDiver1975 @PVince81
The text was updated successfully, but these errors were encountered: