Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test previews via webDAV API tests #37156

Closed
2 tasks done
individual-it opened this issue Mar 23, 2020 · 4 comments
Closed
2 tasks done

test previews via webDAV API tests #37156

individual-it opened this issue Mar 23, 2020 · 4 comments
Assignees
@swoichha
Labels
QA:p2 QA:team

Comments

@individual-it
Copy link
Member

individual-it commented Mar 23, 2020 •
edited
Loading

@individual-it individual-it mentioned this issue Apr 8, 2020
Merged
11 tasks
@phil-davis
Copy link
Contributor

phil-davis commented Apr 9, 2020 •
edited by swoichha
Loading

PR #37166 has been merged. It would be useful to now also add:

  • test scenarios that set the maximum size of a preview (e.g. to 32x32) and then check that previews up to 32x32 can be fetched, but that larger preview requests do not come (or maybe they reply with a 32x32 preview). And try some combinations of prevview max height and width.

@swoichha swoichha mentioned this issue Apr 9, 2020
Merged
11 tasks
@phil-davis
Copy link
Contributor

I added this to server QA/CI project so it is still seen. The new scenarios are being added to enhance core coverage anyway.

@swoichha swoichha mentioned this issue Apr 15, 2020
Merged
11 tasks
@phil-davis
Copy link
Contributor

@individual-it see the linked PRs. Is this enough tests?
And the scenarios seem to have been sorted out for OCIS also.
Close?

@individual-it
Copy link
Member Author

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swoichha swoichha

Labels
QA:p2 QA:team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@phil-davis @individual-it @swoichha