Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

Implement dav file preview API like in OC10 #13

Merged
merged 7 commits into from
Mar 19, 2020
Merged

Implement dav file preview API like in OC10 #13

merged 7 commits into from
Mar 19, 2020

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Mar 18, 2020

File structure might not be perfect but must be move anyways when we want to merge the other webdav related code into this repo.

@C0rby C0rby requested review from IljaN, butonic and refs March 18, 2020 13:36
@update-docs
Copy link

update-docs bot commented Mar 18, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Member

@refs refs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Just a few nitpicks

pkg/dav/thumbnails/thumbnail.go Outdated Show resolved Hide resolved
pkg/dav/thumbnails/thumbnail.go Outdated Show resolved Hide resolved
pkg/dav/thumbnails/thumbnail.go Outdated Show resolved Hide resolved
pkg/service/v0/logging.go Show resolved Hide resolved
pkg/service/v0/tracing.go Show resolved Hide resolved
@C0rby C0rby requested a review from refs March 18, 2020 14:05
pkg/service/v0/service.go Show resolved Hide resolved
@refs
Copy link
Member

refs commented Mar 19, 2020

no idea why ownClouders complains the cyclomatic complexity increases are always bad (red). It should report when the complexity goes over 5 or 7

@ownclouders
Copy link

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- pkg/service/v0/service.go  2
- pkg/dav/thumbnails/thumbnail.go  4
         

See the complete overview on Codacy

Copy link
Member

@refs refs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@C0rby C0rby dismissed DeepDiver1975’s stale review March 19, 2020 13:58

We discussed your thoughts.

@C0rby C0rby merged commit 711d1be into master Mar 19, 2020
@C0rby C0rby deleted the thumbnail-api branch March 19, 2020 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants