Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps page pulls in all groups at once, can cause long loading time #9012

Closed
blizzz opened this issue Jun 12, 2014 · 4 comments
Closed

Apps page pulls in all groups at once, can cause long loading time #9012

blizzz opened this issue Jun 12, 2014 · 4 comments

Comments

@blizzz
Copy link
Contributor

blizzz commented Jun 12, 2014

By https://github.com/owncloud/core/blob/master/settings/apps.php#L32 all groups are loaded. On bigger LDAP setups (my test setup here > 7k groups) this will lead to long loading times.

To reproduce:

  1. create a huge amount of groups (preferably with LDAP)
  2. open apps page

cc @icewind1991

@MTRichards MTRichards added this to the ownCloud 7.0.1 milestone Jun 20, 2014
@craigpg craigpg modified the milestones: 2014-sprint-03-next, 2014-sprint-02-current Sep 2, 2014
@MTRichards
Copy link
Contributor

#9014 #9201 Related

@PVince81
Copy link
Contributor

PVince81 commented Sep 5, 2014

We should probably only load the groups when needed, which is in this specific situation:

  1. App is enabled (or has just been enabled)
  2. "Enable for groups" checkbox is checked

Only then load the groups, maybe show a spinner instead of the select box, then show the select box.
That's still not lazy loading like for #8507 but still a better experience in general for the apps page.

@PVince81
Copy link
Contributor

PVince81 commented Sep 9, 2014

Another idea is to just use select2 with ajax like it was done here #10558

@PVince81 PVince81 self-assigned this Sep 9, 2014
@craigpg craigpg modified the milestones: 2014-sprint-04-current, 2014-sprint-03, 2014-sprint-05-next Sep 15, 2014
@craigpg craigpg modified the milestones: 2014-sprint-06-next, 2014-sprint-05-current Sep 29, 2014
@PVince81
Copy link
Contributor

PVince81 commented Oct 7, 2014

Fixed by #10968

@PVince81 PVince81 closed this as completed Oct 7, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants