remove a left over that uselessly fetches all users #10878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 - makes sense, great that you caught this. |
|
very cool! 👍 Please also backport |
|
Thnaks. it is correct in master and done for the stable6 port, i.e. does not need to be ported to anywhere else. |
|
waiting for Jenkins before merging |
|
👍 Thx for noticing this! |
|
A new inspection was created. |
|
🚀 Test Passed. 🚀 |
butonic
added a commit
that referenced
this pull request
Sep 5, 2014
remove a left over that uselessly fetches all users
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing this line slipped in #10558 while it was in the original PR #8507. It causes all users to be fetched upon opening admin page when files_external is enabled. The placeholder they are assigned to has been removed in the mentioned PRs.
@butonic @LukasReschke @PVince81