Put session data in single field for speed #18913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasReschke
added
2 - Developing
discussion
3 - To Review
and removed
3 - To Review
2 - Developing
discussion
labels
|
sweeeet 👍 |
| $encryptedValue = $this->crypto->encrypt(json_encode($value), $this->passphrase); | ||
| $this->session->set($key, $encryptedValue); | ||
| $this->sessionValues[$key] = $value; | ||
| $encryptedValue = $this->crypto->encrypt(json_encode($this->sessionValues), $this->passphrase); |
There was a problem hiding this comment.
Could we also batch writes? maybe write in the destructor?
LukasReschke
force-pushed
the
put-in-single-field-for-speed
branch
from
ddbc277
to
fd5c360
Compare
|
LukasReschke
force-pushed
the
put-in-single-field-for-speed
branch
from
fd5c360
to
b085071
Compare
This prevents decrypting values multiple times.
LukasReschke
force-pushed
the
put-in-single-field-for-speed
branch
from
b085071
to
0b91087
Compare
|
A new inspection was created. |
|
@icewind1991 @MorrisJobke Mind a review? THX. |
|
|
|
👍 looks good |
|
better 👍 |
LukasReschke
added a commit
that referenced
this pull request
Sep 9, 2015
Put session data in single field for speed
|
Regression: #19273 |
|
Nope. Not me to blame. 🙊 🙈 🙉 |
|
I didn't git blame you, only git bisected 😉 |
|
Hahaha 😄 😆 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will result in only one decryption and encryption call per request resulting in a better performance. Now the overhead is about 2ms for the encryption which is negligible. Especially since I found another bottleneck that stealing us
20ms50ms that I have fixed in #18914 🙊Ref #18482 (comment)
cc @karlitschek @icewind1991