Fix issues where some user settings cannot be loaded when the user id… #25686
Conversation
|
@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @blizzz and @LukasReschke to be potential reviewers |
| @@ -156,6 +156,11 @@ protected function getUserObject($uid, $backend, $cacheUser = true) { | |||
| return $this->cachedUsers[$uid]; | |||
| } | |||
|
|
|||
| $uid = $backend->loginName2UserName($uid); | |||
| if (isset($this->cachedUsers[$uid])) { | |||
There was a problem hiding this comment.
@DeepDiver1975 what's the reason behind searching the cache twice?
There was a problem hiding this comment.
Second time is done because of uid was remapped in the loginname2username call.
Lets say the user name is VicDeo but you Login with vicdeo: first time uid is vicdeo - second time uid is VicDeo
There was a problem hiding this comment.
@DeepDiver1975 Thus cache keys VicDeo and vicdeo will return two different objects.
Looks like some mess still left due to this.
There was a problem hiding this comment.
should we do a case insensitive search in the cache - it that what you are proposing.
DeepDiver1975
force-pushed
the
fix-case-sensitive-settings
branch
2 times, most recently
from
f37f480
to
d8a6596
Compare
… differs in case sensitivity - fixes #25684
DeepDiver1975
force-pushed
the
fix-case-sensitive-settings
branch
from
d8a6596
to
33e782b
Compare
|
@VicDeo please rereview, comments were addressed I think |
|
👍 Works |
|
@PVince81 shall we backport this - this is biting our user base since ever .... |
|
@DeepDiver1975 I'd say backport at least to 9.1.1. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
… differs in case sensitivity - fixes #25684