Changes to get new features work for impersonate app #27629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PVince81 Kindly review my change. |
PVince81
reviewed
Apr 12, 2017
core/templates/layout.user.php
Outdated
| @@ -88,7 +88,13 @@ | |||
| </li> | |||
| <?php endforeach; ?> | |||
| <li> | |||
| <a id="logout" <?php print_unescaped(OC_User::getLogoutAttribute()); ?>> | |||
| <a id="logout" <?php | |||
| if(\OC::$server->getAppConfig()->getValue('impersonate', 'enabled', '') !== '') { | |||
There was a problem hiding this comment.
👎 please, no app-specific code in core
There was a problem hiding this comment.
sure. Will take care of this.
PVince81
reviewed
Apr 12, 2017
| @@ -63,6 +63,8 @@ public function __construct( $renderAs, $appId = '' ) { | |||
| // yes - should be injected .... | |||
| $this->config = \OC::$server->getConfig(); | |||
|
|
|||
| \OC::$server->getEventDispatcher()->dispatch('OC\TemplateLayout::loadAdditionalScripts'); | |||
There was a problem hiding this comment.
this is fine, will likely be useful
Signed-off-by: Sujith H <sharidasan@owncloud.com>
sharidas
force-pushed
the
impersonate-change-master
branch
from
b474d4c
to
edd93cb
Compare
|
@sharidas obsolete ? |
|
@PVince81 I was thinking about this change today when I posted my PR for core today. Can I close this because we no longer need it. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sujith H sharidasan@owncloud.com
Description
Changes to work with new changes proposed for impersonate app.
Related Issue
Motivation and Context
How Has This Been Tested?
The changes has been tested by creating new include groups for impersonate app.
Logout functionality is also tested. Logout makes user reach back to the original user.
Screenshots (if appropriate):
Types of changes
Checklist: