[WIP] add missing getCsrfTokenManager() to new Request for CryptoWrapper

[phil-davis]

Description

Add the (apparently missing) CsrfTokenManager when doing new Request inside registerService for CryptoWrapper.

Related Issue

#28920

Motivation and Context

Try to track down what causes the "CSRF check failed" issue.

How Has This Been Tested?

Let's see what passes/fails :)

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[phil-davis]

History:
#18482 added CryptoWrapper stuff 2015-08-24
#21894 added CSRF manager stuff 2016-01-26
that added a getCsrfTokenManager to a new Request call at https://github.com/owncloud/core/pull/21894/files#diff-4bebfeb572bb49e9d3fc4c1c480813d0R498
But it did not add it to the new Request call further down for CryptoWrapper.

So that is what I have done here.

[phil-davis]

At https://github.com/owncloud/core/blob/master/lib/private/AppFramework/Http/Request.php#L454
not having a csrfTokenManager is one way to fail passesCSRFCheck()

So maybe there is some way the change here will help???

[phil-davis]

This breaks stuff.

[phil-davis]

This is not helpful.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.