Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] update api tests #37337

Merged
merged 1 commit into from
May 7, 2020
Merged

[tests-only] update api tests #37337

merged 1 commit into from
May 7, 2020

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented May 4, 2020

Fixed some issues in reva. This pr updates the acceptance tests for the fixes.

@C0rby C0rby requested a review from individual-it May 4, 2020 14:13
@C0rby C0rby self-assigned this May 4, 2020
@update-docs
Copy link

update-docs bot commented May 4, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #37337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37337   +/-   ##
=========================================
  Coverage     64.55%   64.55%           
  Complexity    19207    19207           
=========================================
  Files          1267     1267           
  Lines         75065    75065           
  Branches       1331     1331           
=========================================
  Hits          48458    48458           
  Misses        26215    26215           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.71% <ø> (ø) 19207.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 366e89d...5431f33. Read the comment docs.

@individual-it individual-it changed the title update api tests [tests-only] update api tests May 5, 2020
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just as a reminder please make sure these changes pass in ocis and ocis-reva repo and merge the corresponding PRs there as soon as you merge this PR here

@C0rby C0rby merged commit 6e3b14f into master May 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the test-fix-ocis-reva branch May 7, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants