[Tests-Only] update reva api tests related to sharing #37396
Conversation
Codecov Report
@@ Coverage Diff @@
## master #37396 +/- ##
=========================================
Coverage 64.68% 64.68%
Complexity 19331 19331
=========================================
Files 1277 1277
Lines 75506 75506
Branches 1331 1331
=========================================
Hits 48838 48838
Misses 26276 26276
Partials 392 392
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
just a small comment, rest looks good, but please make a PR to ocis and ocis-reva where this branch is used to run the tests (you just need to change this line in the drone file https://github.com/owncloud/ocis-reva/blob/master/.drone.star#L104 )
| @@ -67,7 +67,7 @@ Feature: dav-versions | |||
| And user "user0" uploads file "filesForUpload/davtest.txt" asynchronously to "/davtest.txt" in 3 chunks with new chunking and using the WebDAV API | |||
| Then the version folder of file "/davtest.txt" for user "user0" should contain "1" element | |||
|
|
|||
| @smokeTest @issue-ocis-reva-94 | |||
There was a problem hiding this comment.
I would suggest to leave that tag, just for reference
There was a problem hiding this comment.
Why should we leave the issue tag?
PVince81
changed the title
|
there's a conflict also, should we convert this to a draft PR since the fix itself is not merged, so not ready for review yet? |
|
Yes, I think a draft pr would make sense since we don't know when the reva changes will be merged. |
|
it's a bit hard to find :-D |
C0rby
force-pushed
the
update-ocis-reva-tests
branch
from
b230ec6
to
eda6e6d
Compare
C0rby
force-pushed
the
update-ocis-reva-tests
branch
from
eda6e6d
to
6420062
Compare
|
@C0rby I've faked that codecov CI ;-) |
I fixed some issues, unskipped the corresponding tests.
The pr with the fixes:
cs3org/reva#748
Partially fixed
owncloud/ocis-reva#20
Fixed:
owncloud/ocis-reva#26
owncloud/ocis-reva#43
owncloud/ocis-reva#44
owncloud/ocis-reva#94