-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] retag reva issue 249 with the correct issue tags #37672
Conversation
619e93c
to
b906c5b
Compare
last commit looks good so no tests could be enabled I guess? |
sadly not, too many other issue, specially with sharing |
Codecov Report
@@ Coverage Diff @@
## master #37672 +/- ##
=========================================
Coverage 64.74% 64.74%
Complexity 19363 19363
=========================================
Files 1281 1281
Lines 75628 75628
Branches 1333 1333
=========================================
Hits 48966 48966
Misses 26270 26270
Partials 392 392
Continue to review full report at Codecov.
|
b906c5b
to
cedab1c
Compare
Scenario: orphaned shares | ||
Given using OCS API version "1" | ||
And these users have been created with default attributes and without skeleton files: | ||
| username | | ||
| Alice | | ||
| Brian | | ||
And a new browser session for "Alice" has been started |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that session is not needed and without the test work in OCIS
cedab1c
to
4f449b0
Compare
some tests fail in reva, need investigating |
@individual-it ref ? I've merged owncloud/ocis-reva#362 now as it was green |
4f449b0
to
0ccc590
Compare
I've missed tagging/skipping one test in delete shares https://github.com/owncloud/core/pull/37672/files#diff-35aaca9e75175697f0f65df02f6bd140R181 now it should work |
Description
this PR is on top of #37656, so only review the last commit here
owncloud/ocis-reva#249 is fixed, so find all scenarios tagged with that issue and find out if they should work and enable it or retag with the correct issue
Related Issue
Motivation and Context
clean up
How Has This Been Tested?
owncloud/ocis-reva#365
Screenshots (if appropriate):
Types of changes
Checklist: