Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] retag reva issue 249 with the correct issue tags #37672

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Jul 9, 2020

Description

this PR is on top of #37656, so only review the last commit here

owncloud/ocis-reva#249 is fixed, so find all scenarios tagged with that issue and find out if they should work and enable it or retag with the correct issue

Related Issue

Motivation and Context

clean up

How Has This Been Tested?

owncloud/ocis-reva#365

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@PVince81
Copy link
Contributor

PVince81 commented Jul 9, 2020

last commit looks good

so no tests could be enabled I guess?

@individual-it
Copy link
Member Author

last commit looks good

so no tests could be enabled I guess?

sadly not, too many other issue, specially with sharing

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #37672 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37672   +/-   ##
=========================================
  Coverage     64.74%   64.74%           
  Complexity    19363    19363           
=========================================
  Files          1281     1281           
  Lines         75628    75628           
  Branches       1333     1333           
=========================================
  Hits          48966    48966           
  Misses        26270    26270           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (ø) 19363.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5574a5a...0ccc590. Read the comment docs.

Scenario: orphaned shares
Given using OCS API version "1"
And these users have been created with default attributes and without skeleton files:
| username |
| Alice |
| Brian |
And a new browser session for "Alice" has been started
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that session is not needed and without the test work in OCIS

@individual-it
Copy link
Member Author

some tests fail in reva, need investigating

@PVince81
Copy link
Contributor

PVince81 commented Jul 9, 2020

@individual-it ref ?

I've merged owncloud/ocis-reva#362 now as it was green

individual-it added a commit to owncloud/ocis-reva that referenced this pull request Jul 9, 2020
@individual-it
Copy link
Member Author

I've missed tagging/skipping one test in delete shares https://github.com/owncloud/core/pull/37672/files#diff-35aaca9e75175697f0f65df02f6bd140R181 now it should work
retrying tests in ocis-reva owncloud/ocis-reva#365

@individual-it individual-it merged commit 20ba9d7 into master Jul 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the retag-reva-issue-249 branch July 9, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot get information of a specific share by providing share_id
2 participants