Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-only] adjust tests for EOS storage #37796

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Aug 10, 2020

Description

  1. delete @skipOnOcis-EOS-Storage tags because we have now the expected failures list
  2. introduce STORAGE_DRIVER setting, this setting is used to generate the correct delete command to delete user data
  3. hack to create user storage on EOS storage createEOSStorageHome() after deleting the user and recreating it we need an extra request to create the user home storage on EOS
  4. when creating a user use guid and uid numbers (needed for EOS)
  5. when testing on OCIS delete all shares of all users before deleting the user - this is needed because shares are not deleted automatically when user is deleted

How Has This Been Tested?

owncloud/ocis#704

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@dpakach dpakach force-pushed the uid-gid-user-create branch 2 times, most recently from 9e1adaf to 92423bd Compare August 13, 2020 12:47
@individual-it
Copy link
Member

I've rebased on current master and will take this over, because I'm currently working on EOS tests

@individual-it individual-it self-assigned this Oct 15, 2020
@individual-it individual-it force-pushed the uid-gid-user-create branch 2 times, most recently from 5b4eac9 to 3ac6198 Compare October 16, 2020 05:15
@individual-it individual-it changed the title [Tests-only]Use Uid and gid number while creating user [Tests-only] adjust tests for EOS storage Oct 16, 2020
@individual-it individual-it marked this pull request as ready for review October 16, 2020 07:54
@phil-davis
Copy link
Contributor

@individual-it squash?

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants