-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests-Only] Add some more flexible provisioning API tests for getUsers #37882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we don't want to have to keep changing core to keep track of failing tests in OCIS.
This should be added as comments in OCIS expected-failures file(s). See the existing comments in that file, and we can add to them.
Codecov Report
@@ Coverage Diff @@
## master #37882 +/- ##
=========================================
Coverage 64.75% 64.75%
Complexity 19403 19403
=========================================
Files 1285 1285
Lines 75823 75823
Branches 1336 1336
=========================================
Hits 49096 49096
Misses 26333 26333
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@individual-it is my comment correct above ^ about putting the issue links into expected-failures? |
Codecov Report
@@ Coverage Diff @@
## master #37882 +/- ##
=========================================
Coverage 64.75% 64.75%
Complexity 19403 19403
=========================================
Files 1285 1285
Lines 75823 75823
Branches 1336 1336
=========================================
Hits 49096 49096
Misses 26333 26333
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@phil-davis yes, as we have now the expected failures files in the other repos, I would agree to put the issue numbers there, specially if they change the line numbers in the tests |
b897277
to
bfb3cf1
Compare
bfb3cf1
to
1744ecd
Compare
e52569c
to
9884ec1
Compare
Description
Add some tests for provisoning API "get users" that do not require a user "admin" to exist.
Related Issue
Types of changes
Checklist: