Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Add some more flexible provisioning API tests for getUsers #37882

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Sep 3, 2020

Description

Add some tests for provisoning API "get users" that do not require a user "admin" to exist.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jasson99 jasson99 self-assigned this Sep 3, 2020
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we don't want to have to keep changing core to keep track of failing tests in OCIS.
This should be added as comments in OCIS expected-failures file(s). See the existing comments in that file, and we can add to them.

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #37882 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37882   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19403    19403           
=========================================
  Files          1285     1285           
  Lines         75823    75823           
  Branches       1336     1336           
=========================================
  Hits          49096    49096           
  Misses        26333    26333           
  Partials        394      394           
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (ø) 19403.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d91f79...db900e7. Read the comment docs.

@phil-davis
Copy link
Contributor

@individual-it is my comment correct above ^ about putting the issue links into expected-failures?

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #37882 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37882   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19403    19403           
=========================================
  Files          1285     1285           
  Lines         75823    75823           
  Branches       1336     1336           
=========================================
  Hits          49096    49096           
  Misses        26333    26333           
  Partials        394      394           
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (ø) 19403.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 640bba7...9884ec1. Read the comment docs.

@individual-it
Copy link
Member

@phil-davis yes, as we have now the expected failures files in the other repos, I would agree to put the issue numbers there, specially if they change the line numbers in the tests

@jasson99 jasson99 force-pushed the fixAddUsersToHaveEmailContainingUsername branch 2 times, most recently from b897277 to bfb3cf1 Compare September 7, 2020 10:44
@jasson99 jasson99 force-pushed the fixAddUsersToHaveEmailContainingUsername branch from bfb3cf1 to 1744ecd Compare September 7, 2020 11:03
@phil-davis phil-davis force-pushed the fixAddUsersToHaveEmailContainingUsername branch from e52569c to 9884ec1 Compare September 14, 2020 03:06
@phil-davis phil-davis merged commit ce3eb51 into master Sep 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the fixAddUsersToHaveEmailContainingUsername branch September 14, 2020 03:08
@phil-davis phil-davis changed the title [Tests-Only]Tag the failing tests of provisioning api with correct issues [Tests-Only] Add some more flexible provisioning API tests for getUsers Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants