Authentication fixes #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use constant for storage field prefix * Use localStorage instead of sessionStorage so the token is persisted through browser sessions * Clean stale state entries more often * Perform silent renew if the token is already expired on user load
javfg
requested review from
fschade,
kulmann,
pascalwengerter and
lookacat
as code owners
javfg
commented
Oct 15, 2021
Comment on lines
+90
to
+99
| mgr.signinSilent().then((_, reject) => { | ||
| if (reject) { | ||
| mgr.clearStaleState(store, 0) | ||
| return null | ||
| } | ||
| return user.access_token | ||
| }) | ||
| } else { | ||
| return user.access_token | ||
| } |
There was a problem hiding this comment.
By the way, let me know if you want me to switch this to use await.
There was a problem hiding this comment.
Keep in mind this would require a couple more functions to become async, including initApp, are you sure the added complexity is worth it?
There was a problem hiding this comment.
Probably something for a different PR 😅
|
Thanks for taking care! Please also add a changelog item in |
kulmann
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi ownClouders! 👋
While working in integrating ownCloud in Indico via the file-picker, I found some problems with the authentication.
Everything was working fine as long as the access token was kept valid. But if I let the token expire and then tried to open the file-picker again, it froze in the loading spinner. Turns out it was not trying to issue a renewal after loading the user, and so, no valid token is available to authenticate.
To solve this, I added an expiry check and token renewal when the user is loaded.
While at it, I also moved the token storage to
localStorageinstead ofsessionStorage. This enables persistence even if the user closes the browser. To mitigate possible stale tokens, I increased the frequency of stale entry cleanup (whenever an error occurs).Let me know if you see any problems in that. Also, feel free to ask me to split the PR if you think it's worth it.
Cheers!