Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files: Delete a file or folder from my structure. #22

Closed
10 tasks
jesmrec opened this issue Apr 9, 2018 · 5 comments
Closed
10 tasks

Files: Delete a file or folder from my structure. #22

jesmrec opened this issue Apr 9, 2018 · 5 comments

Comments

@jesmrec
Copy link
Contributor

jesmrec commented Apr 9, 2018

As a user, i want the posibility to delete a file, so that i can get rid of it if i am not interested anymore

AC:

  • Set the option to delete in the file list

  • Set the option to delete in the preview of the files

  • Set a dialog in order to let the user choose between removing locally or from server

  • Remove the file locally in case the user chose that option

  • Send the request and get the response in case the user deletes from server

  • Handle issues

  • On delete from file list: Refresh the list view to show the new status

  • On delete from file preview: leave the preview automatically once the file is delete on the server like "back"

  • If the user tap on "Delete" all the files inside that folder should be deleted locally and on the server (destructive)

  • QA

Mockups:
Delete file from the list
delete file list - file v2

Delete folder
delete file list - folder v2

Delete multiselection
delete multiselection v2

Delete preview
delete preview v2

@jesmrec jesmrec changed the title As a user, i want the posibility to delete a file, so that i can get rid of it if i am not interested anymore Files: Delete a file or folder from my structure. Apr 10, 2018
@javiergonzper
Copy link
Contributor

Updated the mockups taking adding a title in order to know witch file or folder we are deleting.
It helps a lot on files or folder with Extremely long filenames #88

@jesmrec
Copy link
Contributor Author

jesmrec commented Jun 26, 2018

Works for me 👍

@pablocarmu
Copy link
Contributor

pablocarmu commented Jun 26, 2018

A couple of things to comment here:

On delete from file list: Refresh the list view to show the new status

This is automatically done via OCQueryDelegate at the time the delete command call in OCCore finished if you have one OCQuery running involving the file you are deleting. (See implementation of the delegate here)

Handle issues.

Currently, there are no mockups about how to present the possible issues that the SDK provide us in case of any error. We have some options:

  • Use IssuesViewController class like in the BookmarkViewController authentication issues.
  • Use a native UIAlertView with the issue message.

Set a dialog in order to let the user choose between removing locally or from server
Remove the file locally in case the user chose that option

For what we talked about in some calls, there is not going to be a remove locally option (at least at early stages). I think we talked about download the files temporarily for preview in the temp folder and let the system manage it.

In recent additions to the ownCloudSDK there are some mechanisms led by OCFile.h that makes possible to have a retainer and, in the future, create files that last on disk only a fixed amount of time (a few hours, one day, one week...). About this topic, @felix-schwarz can correct me if I'm saying something wrong here.

I'm about to push one pull request with the delete feature working for single and multiple items. There are still some things pending to discuss (See here)

@jesmrec
Copy link
Contributor Author

jesmrec commented Jun 26, 2018

Issues from SDK should be handled in the same way in the whole app, i think. As you posted before, in authentication feature, was used an specific ViewController. It should be the same in other features, unless any technical issue does not allow it.

@pablocarmu pablocarmu mentioned this issue Jun 27, 2018
10 tasks
@pablocarmu pablocarmu self-assigned this Jun 27, 2018
@jesmrec jesmrec added this to the 0.1.0 milestone Jul 2, 2018
@jesmrec
Copy link
Contributor Author

jesmrec commented Aug 9, 2018

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants