Feature/delete

[pablocarmu]

Description

This pull request makes the app able to remove files and folders.
Also includes the first implementation of multi-selection which need further discussion.

Related Issue

#79
#22

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

• (1) With no connection, deleting a file makes the app stucked [FIXED]

[CLAassistant]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ pablocarmu
❌ felix-schwarz
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[jesmrec]

(1)

Steps:

1. Switch connection off
2. Delete a file

Current: A spinner with Deleting appears in a loop. By killing the app, the error appears
Expected: App responses with some kind of error about No connection

iPhone 6S Plus v11

[codecov]

Codecov Report

Merging #91 into master will decrease coverage by 0.04%.
The diff coverage is 0.99%.

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   23.66%   23.61%   -0.05%     
==========================================
  Files          57       57              
  Lines        4880     4814      -66     
==========================================
- Hits         1155     1137      -18     
+ Misses       3725     3677      -48

Impacted Files	Coverage Δ
...tensions/UIAlertController+OCConnectionIssue.swift	0% <0%> (ø)	⬆️
ownCloud/Client/ClientQueryViewController.swift	0% <0%> (ø)	⬆️
ownCloud/Tools/Log.swift	0% <0%> (ø)	⬆️
ownCloud/Theming/TVG/TVGImage.swift	71.69% <100%> (-3.51%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44175dc...019ec35. Read the comment docs.

[jesmrec]

Delete feature works properly from my side in online mode. For offline mode issues, check:

owncloud/ios-sdk#25 (comment)

[felix-schwarz]

I made a couple of minor changes:

• progress feedback uses the Progress object returned by OCCore (which currently doesn't provide information, but will in the future)
• Change UIAlertController category so it is reusable by adding parameters for cancel and destructive labels (it was previously hardcoded to "Cancel"/"Delete")

[jesmrec]

All approved, then merge and close. Great job!