Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Log files browsing" option if log files are disabled #397

Closed
jesmrec opened this issue May 21, 2019 · 5 comments
Closed

Hide "Log files browsing" option if log files are disabled #397

jesmrec opened this issue May 21, 2019 · 5 comments
Assignees
Labels
Milestone

Comments

@jesmrec
Copy link
Contributor

jesmrec commented May 21, 2019

From: #382 (comment)

In View Settings -> Logging -> disable the option "Log File"

Current: Browse log files is displayed, but no logs will be stored there anymore
Expected: Browse log option is hidden, because no file is generated.

The special case is keeping the option visible to check older logs. Not sure if this makes sense, since the logs are something that become outdated very fast

@jesmrec jesmrec added enhancement New feature or request feature:settings labels May 21, 2019
@jesmrec jesmrec mentioned this issue May 21, 2019
16 tasks
@jesmrec jesmrec changed the title Hide Log files browsing option if log files are disabled Hide "Log files browsing" option if log files are disabled May 21, 2019
@michaelstingl
Copy link
Contributor

@jesmrec Are there old files from previous logging sessions that could be accessed?

@jesmrec
Copy link
Contributor Author

jesmrec commented May 21, 2019

if the option is disabled, older logs are not accesible. But, logs get outdated very fast... not sure if this is realistic. When you disable the logs is because you are not interested in logs anymore (saving storage etc..). If we'd rather to keep older logs, we do not have to do anything.

@michaelstingl michaelstingl added this to the 1.1.0-Next milestone Jun 17, 2019
@jesmrec jesmrec added the Estimation - 2 (S) 2 points label Jun 17, 2019
@michaelstingl
Copy link
Contributor

Log file list should be accessible when logging has been stopped. Make it a new section that stays there?

@mneuwert mneuwert self-assigned this Jun 17, 2019
@jesmrec
Copy link
Contributor Author

jesmrec commented Jun 18, 2019

Log file list should be accessible when logging has been stopped. Make it a new section that stays there?

+1

@jesmrec
Copy link
Contributor Author

jesmrec commented Jun 19, 2019

Done in #402

@jesmrec jesmrec closed this as completed Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants