[Release] 1.0.1 #402

jesmrec · 2019-06-10T07:33:06Z

Description

To perform release changes: distribution, QA...

Related Issue

#368

Motivation and Context

First new iOS app release

How Has This Been Tested?

Test Plan:

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Bugfixing:

jesmrec · 2019-06-10T08:34:22Z

(1) [FIXED]

Share options in the card are only visible is the item is already shared. Related with capability handling (latest commits in sharing branch)

codecov · 2019-06-10T08:50:41Z

Codecov Report

Merging #402 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #402   +/-   ##
=======================================
  Coverage   27.02%   27.02%           
=======================================
  Files         263      263           
  Lines       19828    19828           
=======================================
  Hits         5358     5358           
  Misses      14470    14470

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe9442d...186dcac. Read the comment docs.

jesmrec · 2019-06-10T11:50:35Z

(2) [FIXED]

On a non-downlaoded file, open the card
Select "Open In"

Current: Downloading is in foreground forever. Cancel button does not cancel the view
Expected: Card with options to open in is displayed.

jesmrec · 2019-06-10T13:22:32Z

(3) [FIXED]

I did not get specific steps to reproduce this one. Once several files has been downloaded, the countdown does not go till zero. This means, you have only one downloading item, but the status message shows Downloading X items (with X > 1):

any additional info is required to help here?

NOTE: one way to reproduce is swipe pics in gallery mode a bit fast

jesmrec · 2019-06-11T06:56:29Z

(4)

Open PDF file

Current: "Go to page" is missing
Expected: not missing

iPhoneX v12

… was not shared

CLAassistant · 2019-06-11T08:05:50Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

✅ jesmrec
✅ mneuwert
✅ ownclouders
✅ hosy
✅ michaelstingl
❌ felix-schwarz
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

felix-schwarz · 2019-06-11T08:09:15Z

@jesmrec Couldn't reproduce the issue but did some spelunking in the progress summarizer code and addressed the places where progress tracking could possibly break. Please check if you can still reproduce (3).

jesmrec · 2019-06-11T08:22:10Z

(5)

Not sure if we addressed something like this in the past:

Upload a bunch of files
Connection is lost during the transaction
Connection is recovered

Current: Uploads are resumed, but user is asked standly for fails:

Expected: resumed uploads are smooth

jesmrec · 2019-06-11T08:44:49Z

(6)

in the same path as (5)

Delete a bunch of files by using multiselection
Remove connection during the deletion
After a while, recover connection

Current: Deletions are not resumed
Expected: Deletions resumed

iPhoneX v12

codecov · 2019-06-11T09:37:08Z

Codecov Report

Merging #402 into master will increase coverage by 0.03%.
The diff coverage is 5.06%.

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
+ Coverage   27.02%   27.05%   +0.03%     
==========================================
  Files         263      264       +1     
  Lines       19828    19892      +64     
==========================================
+ Hits         5358     5382      +24     
- Misses      14470    14510      +40

Impacted Files	Coverage Δ
ownCloud/AppDelegate.swift	`80% <ø> (-1.09%)`	⬇️
...esentation Controller/CardTransitionDelegate.swift	`0% <0%> (ø)`	⬆️
ownCloud/Client/Viewer/DisplayViewController.swift	`0% <0%> (ø)`	⬆️
...ient/Actions/Actions+Extensions/OpenInAction.swift	`11.29% <0%> (+3.59%)`	⬆️
...ient/Sharing/GroupSharingTableViewController.swift	`0% <0%> (ø)`	⬆️
...ud/Client/Viewer/PDF/PDFViewerViewController.swift	`0% <0%> (ø)`	⬆️
ownCloud/Settings/LogFilesViewController.swift	`0% <0%> (ø)`	⬆️
...tation Controller/CardPresentationController.swift	`0% <0%> (ø)`	⬆️
...d Presentation Controller/CardViewController.swift	`0% <0%> (ø)`
ownCloud/Client/Actions/MoreViewController.swift	`0% <0%> (ø)`	⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe9442d...eeeac33. Read the comment docs.

* Fixed an issue with go-to button not being shown in PDF viewer * Added accessibility labels to bar button items in the PDF viewer

jesmrec · 2019-06-11T13:45:41Z

(7) [NOT REPRODUCIBLE]

Downloading an item makes the app crash

jesmrec · 2019-06-11T16:14:06Z

(8) [WONT FIX]

In Files App, select several items in non-root folder and the option "Move"
As target, select another oC account (its root folder)

Current: Items moved to the source account, in the root folder

We had some issues in moving stuff between accounts due to an Apple issues, or improvements to do:

#237 (comment)
#237 (comment)

And more related issues in that release attempt, but i did not notice the current behaviour. If i select as target a different account, i do not expect the content copied to the same account. I expect:

Copied to the selected target
Not copied (error message or something?)

- extend ActionWillRunHandler with a completionHandler and adding a new .perform() method to wrap .willRun() and .run(), allowing for actions to trigger view controller dismissals, wait for them to finish and then present their own view controllers - Card upgrades, improvement and fixes - fix MoreViewController "shaking" on initial presentation - create new CardPresentationSizing protocol to allow view controllers to provide sizing information to CardPresentationController - allow disabling the handle and the ability to dismiss by tapping in the background - create CardViewController as base class for future view controllers that should be presented as cards - Add new DownloadItemsHUDViewController class (a CardViewController subclass) to modally download files, provide a summary, allow cancellation and simplified retrieval of the corresponding OCFile objects - Clean up OpenInAction and rewrite most of it to use DownloadItemsHUDViewController - KVOWaiter allows waiting for an object's value to change, check if the change meets the criteria and then run a block once. Ended up not being used and is therefore not included in the builds. But since it may be useful in the future, left the source code regardless. - Add ProgressSummary.update(progressView:) convenience method

…s-app into release/1.0.1_June19

felix-schwarz · 2019-06-11T20:27:35Z

(9) [FIXED]

When tapping the dots next to an item, the card first overreaches, then drops back into place.

Expected: a smooth transition without overreach and drop back.
Actual: he card first overreaches, then drops back into place.

Fixed as of 43f0769

felix-schwarz · 2019-06-11T20:32:32Z

(10) [FIXED]

"Open in" action fragile, not offering full multi selection support.

Expected: after selecting "Open in", the app shows accurate download progress information and allows cancelling the downloads entirely.
Actual: the app shows only the download progress of the last started download and will allow cancelling only the last started download

Fixed as of 43f0769 and updated with a more pleasing UI:

felix-schwarz · 2019-06-12T10:05:46Z

(2)

On a non-downlaoded file, open the card

Select "Open In"

Current: Downloading is in foreground forever. Cancel button does not cancel the view
Expected: Card with options to open in is displayed.

Missed this. Should be the same as (10) and fixed.

…eduling downloads - Update ios-sdk, fixing findings (5) + (6)

felix-schwarz · 2019-06-12T10:17:32Z

@jesmrec Fixed (5) and (6) as of 0151119. The reason was that not all network error codes indicating failure due to missing network connectivity were checked for - and some requests could get silently dropped for that reason. Now also includes things like DNS lookup failure, data not being allowed, international roaming to be disabled, etc.

mneuwert · 2019-06-19T15:01:49Z

(20) [FIXED]

Glitches when creating new folder:

Create new folder
As soon as placeholder folder icon appears, tap it
New view is opened and it shows first the sub-folder with same name and then message "Folder removed"
Go back to the parent folder and the new folder is visible twice.
Trigger pull to refresh and the second copy of the folder is disappearing.

…xtension on bitrise build

mneuwert · 2019-06-20T09:52:36Z

@jesmrec Fixed (20) with 70bd66c commit

…frequency

…to release/1.0.1_June19

…ser a explanation for the "Immediately" lock interval

* Push 21 Figma assets via relay.graphics * Update Contents.json * added deleted submodules by relay commit

- Revert previous fix for (20) that had undesirable side effects for working offline

- Fix AppIcon pngs and run them through ImageOptim to save up to several MBs of space

- changed steps to generate screenshots - added demo accounts - changed wording - new file names - added upload step to fastfile - updated fastlane

felix-schwarz

Approved without review to allow merging.

* Added TestFlight builds to CHANGELOG.md * Release version 1.0.1 (June 2019)

change version number 1.0 -> 1.0.1

7cd95bb

jesmrec mentioned this pull request Jun 10, 2019

[Release] 1.0.1 #368

Closed

38 tasks

jesmrec self-assigned this Jun 10, 2019

hosy added 2 commits June 10, 2019 20:36

Merge branch 'master' into release/1.0.1_June19

73ed1b0

Merge branch 'master' into release/1.0.1_June19

4ef9bd6

hosy and others added 2 commits June 11, 2019 09:29

Fixed QA finding (1). "Share item" menu item was not visible, if item…

186dcac

… was not shared

Fix finding (3)

b9338fe

mneuwert and others added 2 commits June 11, 2019 13:42

Fixed an issue with go-to button not being shown in PDF viewer (#403)

1b5a6ef

* Fixed an issue with go-to button not being shown in PDF viewer * Added accessibility labels to bar button items in the PDF viewer

Version Bump to 121

9bd63bf

felix-schwarz added 2 commits June 11, 2019 22:25

Merge branch 'release/1.0.1_June19' of https://github.com/owncloud/io…

4067784

…s-app into release/1.0.1_June19

- Switch to release/1.0.1 branch for ios-sdk

41e22c7

- Add "Preparing" message to DownloadItemsHUDViewController while sch…

0151119

…eduling downloads - Update ios-sdk, fixing findings (5) + (6)

jesmrec mentioned this pull request Jun 19, 2019

Hide "Log files browsing" option if log files are disabled #397

Closed

hosy and others added 5 commits June 19, 2019 21:07

set unlocked value, if passcode was set/unset in settings

360097a

added some debug messages to debug pass code lock for file provider e…

9ed013d

…xtension on bitrise build

- added some additional debug output

69cf238

removed debug output and added new else if criteria

b38ca1a

Fixed (20). Dissallowing to select placeholder items in the file list

70bd66c

hosy and others added 10 commits June 20, 2019 19:49

changed translation key from "Always" to "Immediately" for pass code …

fed81c8

…frequency

added debug logs for bitrise build (pass code testing in files app)

b9de2ba

Merge branch 'release/1.0.1_June19' of github.com:owncloud/ios-app in…

543388a

…to release/1.0.1_June19

removed debug messages for file provider

2ce2d51

added footer title for "Lock Application" settings, the display the u…

435bfbd

…ser a explanation for the "Immediately" lock interval

Import AppIcon from Figma (#406)

bd21005

* Push 21 Figma assets via relay.graphics * Update Contents.json * added deleted submodules by relay commit

- Fix issue (20) via SDK fixes

dd750fc

- Revert previous fix for (20) that had undesirable side effects for working offline

- Fix .gitmodules

5fc85ef

- Fix AppIcon pngs and run them through ImageOptim to save up to several MBs of space

- Switch SDK to release/1.0.1 commit on ios-sdk/master

bbd3540

- added new screens (#409)

c5f5802

- changed steps to generate screenshots - added demo accounts - changed wording - new file names - added upload step to fastfile - updated fastlane

felix-schwarz self-requested a review June 24, 2019 20:50

felix-schwarz approved these changes Jun 24, 2019

View reviewed changes

hosy self-requested a review June 24, 2019 20:52

hosy approved these changes Jun 24, 2019

View reviewed changes

hosy and others added 3 commits June 25, 2019 00:26

using tagged SDK from master

6dde56a

added changelog for released versions

3171aa1

CHANGELOG.md for 1.0.1 release (#407)

eeeac33

* Added TestFlight builds to CHANGELOG.md * Release version 1.0.1 (June 2019)

hosy merged commit 2d1fac8 into master Jun 24, 2019

delete-merged-branch bot deleted the release/1.0.1_June19 branch June 24, 2019 23:08

jesmrec added the Approved by QA Approved by QA label Jun 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Release] 1.0.1 #402

[Release] 1.0.1 #402

jesmrec commented Jun 10, 2019 •

edited

Loading

jesmrec commented Jun 10, 2019 •

edited

Loading

codecov bot commented Jun 10, 2019 •

edited

Loading

jesmrec commented Jun 10, 2019 •

edited

Loading

jesmrec commented Jun 10, 2019 •

edited

Loading

jesmrec commented Jun 11, 2019

CLAassistant commented Jun 11, 2019 •

edited

Loading

felix-schwarz commented Jun 11, 2019

jesmrec commented Jun 11, 2019 •

edited

Loading

jesmrec commented Jun 11, 2019

codecov bot commented Jun 11, 2019 •

edited

Loading

jesmrec commented Jun 11, 2019 •

edited

Loading

jesmrec commented Jun 11, 2019 •

edited

Loading

felix-schwarz commented Jun 11, 2019 •

edited by jesmrec

Loading

felix-schwarz commented Jun 11, 2019 •

edited by jesmrec

Loading

felix-schwarz commented Jun 12, 2019

(2)

felix-schwarz commented Jun 12, 2019

mneuwert commented Jun 19, 2019 •

edited by jesmrec

Loading

mneuwert commented Jun 20, 2019

felix-schwarz left a comment

[Release] 1.0.1 #402

[Release] 1.0.1 #402

Conversation

jesmrec commented Jun 10, 2019 • edited Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bugfixing:

jesmrec commented Jun 10, 2019 • edited Loading

(1) [FIXED]

codecov bot commented Jun 10, 2019 • edited Loading

Codecov Report

jesmrec commented Jun 10, 2019 • edited Loading

(2) [FIXED]

jesmrec commented Jun 10, 2019 • edited Loading

(3) [FIXED]

jesmrec commented Jun 11, 2019

(4)

CLAassistant commented Jun 11, 2019 • edited Loading

felix-schwarz commented Jun 11, 2019

jesmrec commented Jun 11, 2019 • edited Loading

(5)

jesmrec commented Jun 11, 2019

(6)

codecov bot commented Jun 11, 2019 • edited Loading

Codecov Report

jesmrec commented Jun 11, 2019 • edited Loading

(7) [NOT REPRODUCIBLE]

jesmrec commented Jun 11, 2019 • edited Loading

(8) [WONT FIX]

felix-schwarz commented Jun 11, 2019 • edited by jesmrec Loading

(9) [FIXED]

felix-schwarz commented Jun 11, 2019 • edited by jesmrec Loading

(10) [FIXED]

felix-schwarz commented Jun 12, 2019

(2)

felix-schwarz commented Jun 12, 2019

mneuwert commented Jun 19, 2019 • edited by jesmrec Loading

(20) [FIXED]

mneuwert commented Jun 20, 2019

felix-schwarz left a comment

Choose a reason for hiding this comment

jesmrec commented Jun 10, 2019 •

edited

Loading

jesmrec commented Jun 10, 2019 •

edited

Loading

codecov bot commented Jun 10, 2019 •

edited

Loading

jesmrec commented Jun 10, 2019 •

edited

Loading

jesmrec commented Jun 10, 2019 •

edited

Loading

CLAassistant commented Jun 11, 2019 •

edited

Loading

jesmrec commented Jun 11, 2019 •

edited

Loading

codecov bot commented Jun 11, 2019 •

edited

Loading

jesmrec commented Jun 11, 2019 •

edited

Loading

jesmrec commented Jun 11, 2019 •

edited

Loading

felix-schwarz commented Jun 11, 2019 •

edited by jesmrec

Loading

felix-schwarz commented Jun 11, 2019 •

edited by jesmrec

Loading

mneuwert commented Jun 19, 2019 •

edited by jesmrec

Loading