Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0.0 #352

Merged
merged 82 commits into from
Apr 29, 2019
Merged

Version 1.0.0 #352

merged 82 commits into from
Apr 29, 2019

Conversation

jesmrec
Copy link
Contributor

@jesmrec jesmrec commented Apr 4, 2019

Description

Stuff for the release 1.0.0 after freezing the code

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jesmrec jesmrec added this to the 1.0.0-Current milestone Apr 4, 2019
@jesmrec jesmrec mentioned this pull request Apr 4, 2019
75 tasks
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #352 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #352      +/-   ##
=========================================
+ Coverage      30%     30%   +<.01%     
=========================================
  Files         234     234              
  Lines       16316   16315       -1     
=========================================
  Hits         4896    4896              
+ Misses      11420   11419       -1
Impacted Files Coverage Δ
ownCloud/Client/ClientQueryViewController.swift 32.76% <ø> (+0.03%) ⬆️
ownCloud/Tools/VendorServices.swift 24.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6583d9f...361b152. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #352 into master will decrease coverage by 0.24%.
The diff coverage is 37.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
- Coverage      30%   29.76%   -0.25%     
==========================================
  Files         234      241       +7     
  Lines       16316    16618     +302     
==========================================
+ Hits         4896     4946      +50     
- Misses      11420    11672     +252
Impacted Files Coverage Δ
ownCloud/Client/ClientActivityCell.swift 0% <0%> (ø) ⬆️
...Client/Actions/Actions+Extensions/MoveAction.swift 20% <0%> (ø) ⬆️
ownCloud/UI Elements/ImageScrollView.swift 0% <0%> (ø) ⬆️
ownCloud/Gallery/GalleryHostViewController.swift 0% <0%> (ø) ⬆️
ownCloud/SDK Extensions/OCItem+Extension.swift 80.74% <0%> (-1.32%) ⬇️
ownCloud/Viewer/ImageDisplayViewController.swift 8% <0%> (+0.18%) ⬆️
ownCloud/Viewer/PDFTocTableViewController.swift 0% <0%> (ø) ⬆️
...ient/Actions/Actions+Extensions/OpenInAction.swift 8.13% <0%> (-1.32%) ⬇️
...Viewer/PDFThumbnailsCollectionViewController.swift 0% <0%> (ø) ⬆️
...nagement/CertificateManagementViewController.swift 0% <0%> (ø) ⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7069ca...f24e48a. Read the comment docs.

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 5 committers have signed the CLA.

✅ jesmrec
✅ ownclouders
✅ mneuwert
✅ hosy
❌ felix-schwarz
You have signed the CLA already but the status is still pending? Let us recheck it.

ownCloud Jenkins and others added 9 commits April 8, 2019 15:33
…rk and whenever editing a bookmark and saving it (previously UI seemed stuck for a couple of seconds)
…tion for OCErrors so they are included when serialized, so they become visible in the Files app, too

- Fixing issue (8) in #237
- Remove trash method and permission flag for items in FP, so "Delete Now" is the only option and Files app shows a warning
- Fixing (11) in #237
- Add new action extension location .plusButton
- Add Action extensions support to provide UIAlertAction objects
- Add .plusButton location to CreateFolder action
- Extend the ClientQueryViewController plusBarButton to include action extensions in the alert that's being shown
- Implementing improvement (15) from #237
felix-schwarz and others added 9 commits April 24, 2019 10:08
        - Make OCCoreManager use an administrative queue for every bookmark, so that one connection closing down or opening up can't hold up another
- Takes advantage of OCCoreManager managing every bookmark independently
	- allowing to select another bookmark if the previous one takes longer to open
	- not show the UI for a bookmark if Settings, Help or Add/Edit Bookmark UI is triggered meanwhile
	- fix crash caused by force-unwrapping self.core in ClientRootViewController.coreReady()
…re already downloaded (issue (46) in #237)

- Fix bug in PDFViewerViewController where CoreGraphics would throw an error when using pdfView with zero size (before properly laying it out)
- Fix (47) "the non-openable files prompt the download progress bar in the "details" view" in #237
* Added HEIC to JPEG conversion

* Localized strings for photo upload settings

* Fixed indentation

* Fixed license header
@jesmrec jesmrec requested a review from hosy April 29, 2019 06:35
Copy link
Contributor

@michaelstingl michaelstingl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelstingl michaelstingl merged commit 8b86fc1 into master Apr 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the release_1.0.0 branch April 29, 2019 10:35
@jesmrec jesmrec mentioned this pull request Apr 30, 2019
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants