This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
change grpc api errors #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs
reviewed
Jul 7, 2020
refs
approved these changes
Jul 7, 2020
kulmann
reviewed
Jul 7, 2020
pkg/service/v0/service.go
Outdated
| @@ -143,6 +144,7 @@ func New(opts ...Option) (s *Service, err error) { | |||
| // TODO don't bother to store fields as we will load the account from disk | |||
|
|
|||
| s = &Service{ | |||
| id: cfg.GRPC.Namespace + cfg.Server.Name, | |||
There was a problem hiding this comment.
With our default values this will evaluate to com.owncloud.apiaccounts, missing a . between the namespace and the name, right?
Signed-off-by: David Christofas <dchristofas@owncloud.com>
C0rby
force-pushed
the
add-error-message-to-responses
branch
from
6c97de7
to
db7afb8
Compare
|
Clones added
============
- pkg/service/v0/service.go 4
See the complete overview on Codacy |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more information to error responses.
I followed the micro example here: https://m3o.com/docs/go-errors.html
Closes #11