Update index after adding/deleting new users and groups

[dpakach]

Update index after adding new users and groups

Related Issue #57

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[ownclouders]

Here is an overview of what got changed by this pull request:

Clones added
============
- pkg/service/v0/groups.go  3
- pkg/service/v0/accounts.go  3
         

See the complete overview on Codacy

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

[kulmann]

Just above the code that you added there is an s.index.Index() and s.index.Delete() call, which is supposed to update the index properly for the created or deleted entity. Recreating the whole index is not an option.

However, the existing code has a bug for indexing new accounts and groups, that I can confirm. The fix is, to wrap the Account / Group into the respective BleveAccount / BleveGroup type. Have a look at the initial indexing to see how it's done:

ocis-accounts/pkg/service/v0/accounts.go

Line 44 in fa35a81

a := &proto.BleveAccount{

So instead of passing an account, you wrap it first:

a := &proto.BleveAccount{
        BleveType: "account",
        Account:    in.Account,
}

and then pass that a into the Index function of the index.

Deleting should work, as it only deletes from the index by Id. Didn't test it, please try / confirm. :-)

[kulmann]

Oh, seeing now, that the account is expanded within the BleveAccount type. Creating it like I stated it above doesn't work. I made this pull request now to fix the broken indexing. Please have a look @dpakach