Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

Assign user role as default to newly created accounts #95

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

IljaN
Copy link
Member

@IljaN IljaN commented Aug 26, 2020

@IljaN IljaN self-assigned this Aug 26, 2020
@update-docs
Copy link

update-docs bot commented Aug 26, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@IljaN IljaN changed the title Assign admin role to newly created accounts. Assign admin role to newly created accounts Aug 26, 2020
pkg/service/v0/accounts.go Outdated Show resolved Hide resolved
@IljaN IljaN force-pushed the assign_admin_role_via_settingssvc branch from 6771bee to 13d1587 Compare August 26, 2020 14:27
@IljaN IljaN requested a review from kulmann August 26, 2020 14:28
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks 👍
please add a changelog, then it's good for merge ;-)

@IljaN IljaN force-pushed the assign_admin_role_via_settingssvc branch from 13d1587 to 69e7515 Compare August 26, 2020 14:34
@IljaN
Copy link
Member Author

IljaN commented Aug 26, 2020

Hmhhh, should we bootstrap a ocis-settings instance inside the test?

@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@IljaN IljaN merged commit 73c8b11 into master Aug 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the assign_admin_role_via_settingssvc branch August 26, 2020 18:19
@kulmann kulmann changed the title Assign admin role to newly created accounts Assign user role as default to newly created accounts Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants