Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS Deps: Remove ldap, update ODS to current, upgrade all #120

Merged
merged 1 commit into from
Aug 30, 2021
Merged

JS Deps: Remove ldap, update ODS to current, upgrade all #120

merged 1 commit into from
Aug 30, 2021

Conversation

pascalwengerter
Copy link
Contributor

Closes all current dependabot PRs and also closes #93

@pascalwengerter pascalwengerter force-pushed the update-js-dependencies branch 2 times, most recently from accd836 to 13fe758 Compare August 30, 2021 12:16
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

wkloucek
wkloucek approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascalwengerter pascalwengerter merged commit 0b06422 into master Aug 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-js-dependencies branch August 30, 2021 12:33
ownclouders pushed a commit that referenced this pull request Aug 30, 2021
commit 0b06422
8af0250 
Merge: dd7070c 1de5749
Author: Pascal Wengerter <pwengerter@owncloud.com>
Date:   Mon Aug 30 13:33:32 2021 +0100

    Merge pull request #120 from owncloud/update-js-dependencies

    JS Deps: Remove ldap, update ODS to current, upgrade all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

is it save to remove LDAP for part Running/configuration-with-ocis in in documentation?
2 participants
@pascalwengerter @wkloucek