Add function to remove share invite using root endpoint #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
S-Panta
force-pushed
the
add-share-invite-using-root-endpoint
branch
4 times, most recently
from
23cffe4
to
36c98c1
Compare
amrita-shrestha
force-pushed
the
add-share-invite-using-root-endpoint
branch
6 times, most recently
from
e83bed1
to
1958911
Compare
amrita-shrestha
force-pushed
the
add-delete-share-invite-from-drive
branch
from
b50f27c
to
13ded81
Compare
amrita-shrestha
force-pushed
the
add-delete-share-invite-from-drive
branch
from
13ded81
to
56af5dc
Compare
amrita-shrestha
requested review from
phil-davis,
S-Panta,
nirajacharya2 and
individual-it
phil-davis
reviewed
Jul 10, 2024
| $managerRole = null; | ||
|
|
||
| if (getenv('OCIS_VERSION') === "stable") { | ||
| $this->markTestSkipped('Ocis version < 6.0.0 does not support creation of drive share invite so delete drive share test has been skipped'); |
There was a problem hiding this comment.
This is correct. It is difficult, or "impossible", to test what happens in ocis V5 if someone tries to delete a drive share, because it is not possible to create a drive share in the first place.
Someone could try to delete a "bogus" drive share, putting some non-existent id. But that would be the same as any "completely wrong" attempt to use the non-existent end-point, and that is already covered by ocis tests.
phil-davis
reviewed
Jul 10, 2024
amrita-shrestha
force-pushed
the
add-delete-share-invite-from-drive
branch
from
3408d8a
to
197e7f8
Compare
|
phil-davis
approved these changes
Jul 10, 2024
ownclouders
pushed a commit
that referenced
this pull request
Jul 10, 2024
Add function to remove share invite using root endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor delete function of Share to work on both permission and root endpoint.
In this PR, ResourceShare has been introduced. Share class is parent class for DriveShare and ResourceShare. ResourceShare will be parent class for ShareLink, ShareCreated.
Part of