-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added code for getting current oCis version #229
Conversation
2e0ec48
to
7f123a5
Compare
7f123a5
to
84ee052
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have an integration test for this?
Then we will know that it works, at least for the happy path.
84ee052
to
b815f23
Compare
Why does the function need to be public? |
IMO it does not need to be public, consumers of the SDK do not need to be able to get the ocis version, anything related to differences of the ocis version should be handled internally. The function should be used to fetch and remember the ocis version. @S-Panta you could also add code in this PR to do "throw an exception about API endpoint not implemented on ocis version less than 6.0.0 " for the existing code that was first introduced in PR #225 - that way the new |
https://drone.owncloud.com/owncloud/ocis-php-sdk/1578/5/3 |
6acdc71
to
2586268
Compare
maybe this wil pass unit tests
|
75b376c
to
90d093e
Compare
Quality Gate passedIssues Measures |
Good - we can reuse a lot of this code when implementing the other root endpoints, where we need to know the ocis version etc. |
* added code for getting current oCis version * added code to handle exception if no endpoint found * addressing reviews * updated code and drone env for master and stable * adding guzzle mock for getting ocis version * adding test for stable ocis for sharing drive via root
New API endpoint could be added in a different version of ocis. oCIS will throw 404 status code , that leads to confusion, whether api request has problem or api endpoint has not implemented.
This PR adds capability api endpoint to get current version of oCIS so that it would be easy to dissect the methods to use in different version of oCIS