This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
Disable OIDC Keep-Alive and instantiate the client once #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
C0rby
approved these changes
May 29, 2020
pkg/middleware/openidconnect.go
Outdated
| @@ -92,6 +91,8 @@ func OpenIDConnect(opts ...ocisoidc.Option) func(next http.Handler) http.Handler | |||
| // The claims we want to have | |||
| var claims ocisoidc.StandardClaims | |||
|
|
|||
| token := header[7:] | |||
There was a problem hiding this comment.
I guess you are cutting of Bearer here? Maybe something like strings.TrimPrefix(header, "Bearer ") or header[len("Bearer "):] could make it more explicit.
IljaN
force-pushed
the
disable_oidc_keep_alive
branch
from
eaa27ca
to
681da9a
Compare
This should reduce file-descriptor leaks.
IljaN
force-pushed
the
disable_oidc_keep_alive
branch
from
681da9a
to
2eb962e
Compare
IljaN
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce file-descriptor leaks.
Related:
owncloud/ocis#268
cs3org/reva#787