This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
only send createhome requests if the account has been migrated #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0rby
force-pushed
the
feature/create-home-if-migrated
branch
3 times, most recently
from
55a1f6b
to
8c75641
Compare
IljaN
force-pushed
the
feature/create-home-if-migrated
branch
from
02f67f3
to
0b7930b
Compare
refs
reviewed
Jul 10, 2020
| token := r.Header.Get("x-access-token") | ||
| if token == "" { |
There was a problem hiding this comment.
do we want to halt every other middleware if the token is not present? Or do we also need to call next.ServeHTTP(w, r) before return?
IljaN
force-pushed
the
feature/create-home-if-migrated
branch
2 times, most recently
from
7da5605
to
9097fcd
Compare
refs
approved these changes
Jul 10, 2020
Signed-off-by: David Christofas <dchristofas@owncloud.com>
IljaN
force-pushed
the
feature/create-home-if-migrated
branch
from
9097fcd
to
17e473b
Compare
IljaN
approved these changes
Jul 10, 2020
|
Complexity increasing per file
==============================
- pkg/middleware/create_home.go 5
See the complete overview on Codacy |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a check if an account has been migrated by getting it from the ocis-accounts service. If no account is returned it means it hasn't been migrated.
Closes #52