Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

prevent segfault in create home middleware #76

Merged
merged 1 commit into from
Jul 23, 2020
Merged

prevent segfault in create home middleware #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/fix-createhome-segfault.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Provide token configuration from config

Fixed a bug that causes the createHome middleware to crash if the createHome response has no Status set

https://github.com/owncloud/ocis-proxy/pull/76
6 changes: 2 additions & 4 deletions pkg/middleware/create_home.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,9 @@ func CreateHome(opts ...Option) func(next http.Handler) http.Handler {

if err != nil {
opt.Logger.Err(err).Msg("error calling CreateHome")
}

if createHomeRes.Status.Code != rpc.Code_CODE_OK {
} else if createHomeRes.Status.Code != rpc.Code_CODE_OK {
err := status.NewErrorFromCode(createHomeRes.Status.Code, "gateway")
opt.Logger.Err(err).Msg("error calling Createhome")
opt.Logger.Err(err).Msg("error when calling Createhome")
}

next.ServeHTTP(w, r)
Expand Down