Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

OCS share response contains domain name #245

Closed
PVince81 opened this issue Jun 3, 2020 · 1 comment
Closed

OCS share response contains domain name #245

PVince81 opened this issue Jun 3, 2020 · 1 comment

Comments

@PVince81
Copy link
Contributor

PVince81 commented Jun 3, 2020

Steps

  1. in tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature replace "welcome.txt" with "textfile0.txt"
  2. apply OCS fixes for create public link cs3org/reva#798
  3. run tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature:212

Expected result

uid_owner "Alice" without domain name

Actual result

uid_owner has unexpected value 'Alice@https://localhost:9200'

This is due to https://github.com/cs3org/reva/blob/master/internal/http/services/owncloud/ocs/conversions/main.go#L305

I'm not sure what logic to use to decide when to include the IDP and when not to.
Or should this be a setup thing ?

@butonic thoughts ?

@PVince81
Copy link
Contributor Author

PVince81 commented Jun 5, 2020

fixed by cs3org/reva#798

@PVince81 PVince81 closed this as completed Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant