OCS fixes for create public link #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return 404 if the target of createPublicLinkShare does not exist. Added default permission in case none was passed in the requested
|
Discovered that "not found" issue when running the tests tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature:212 but omitting the SKELETON_DIR path, so no file was present for share creation. For the perm issue, once the file exists but no permission field is given in tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature:212 the "Atoi" would fail due to empty string. With these fixes the test tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature:212 goes further and bumps against further issues to be fixed separately. |
added 2 commits
June 3, 2020 12:04
OCS response now uses the name field from the share object instead of the one from the request. The old OCS Share API did include the name field even when empty.
Local public shares must not include the IDP in the user id field.
|
fixed the lint issue I've added a bunch of additional fixes, see top post |
PVince81
changed the title
labkode
approved these changes
Jun 3, 2020
C0rby
pushed a commit
to owncloud/reva
that referenced
this pull request
Jun 30, 2020
* OCS public link add default perm + 404 handling Return 404 if the target of createPublicLinkShare does not exist. Added default permission in case none was passed in the requested * OCS fix name field handling OCS response now uses the name field from the share object instead of the one from the request. The old OCS Share API did include the name field even when empty. * OCS remove domain name for local public share Local public shares must not include the IDP in the user id field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@refs FYI