This repository has been archived by the owner on Jan 18, 2021. It is now read-only.
Public Links #133
Closed
Public Links #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
refs
commented
Apr 14, 2020
refs
commented
Apr 14, 2020
refs
commented
Apr 14, 2020
refs
commented
Apr 14, 2020
refs
commented
Apr 14, 2020
| }, | ||
| &cli.StringFlag{ | ||
| Name: "url", | ||
| Value: "localhost:10054", |
refs
commented
Apr 28, 2020
| @@ -136,7 +136,7 @@ func SharingWithConfig(cfg *config.Config) []cli.Flag { | |||
| }, | |||
| &cli.StringFlag{ | |||
| Name: "public-driver", | |||
| Value: "memory", | |||
| Value: "json", | |||
There was a problem hiding this comment.
the json driver has a hard dependency on its db file. This might fail a default ocis run.
|
|
|
Complexity increasing per file
==============================
- pkg/flagset/storagepubliclink.go 1
- pkg/command/storagepubliclink.go 8
Clones added
============
- pkg/command/frontend.go 1
- pkg/command/storageocdata.go 2
- pkg/flagset/storagepubliclink.go 18
- pkg/command/storageroot.go 2
- pkg/command/storagepubliclink.go 10
- pkg/command/storageoc.go 2
Clones removed
==============
+ pkg/command/gateway.go -1
See the complete overview on Codacy |
|
seems we still have hard-coded localhost:10054 ? can we sort this out and make it configurable ? |
|
to solve the CI, please rebase on top of origin/master from the owncloud/ocis-reva repo. |
|
closing in favor of #232 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide
reva-storage-public-linkcommand and its default UNIX configuration.