-
Notifications
You must be signed in to change notification settings - Fork 5
Update reva to v0.1.1-0.20200518061204 #207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hmmm, a strange failure:
wondering if this is related to the Phoenix sidebar changes, but I don't see why it would fail with OCIS |
test is passing locally... attempting a build restart... |
okay, same failure. at least it's consistent...
|
quick attempt: I've now set the screen resolution explicitly to 1920x1080, just in case. to me it seems like maybe during that test on Drone the left sidebar is closed and the action for opening it might be missing |
hmm, I tested locally with 768x1024 but it still manages to open the sidebar, so it might be something else... |
the failure also exists on an other PR: https://cloud.drone.io/owncloud/ocis-reva/340/3/10 so it's not related to the update |
raised test PR owncloud/web#3471 to check if it was failing already on Phoenix master |
tests pass on Phoenix master: owncloud/web#3471 but not sure if it's 100% the same thing @individual-it can you help ? |
It looks like we are not using the phoenix code from the phoenix repo but the code that is compiled into ocis, so we don't get the current phoenix. that is a mistake, @dpakach please fix that |
b3138c5
to
6b4d985
Compare
Rebased and removed the forced screen resolution which did not solve the issue anyway |
No description provided.