Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Update reva to v0.1.1-0.20200518061204 #207

Merged
merged 2 commits into from
May 19, 2020

Conversation

PVince81
Copy link
Contributor

No description provided.

@PVince81 PVince81 requested a review from micbar May 18, 2020 07:41
@PVince81 PVince81 self-assigned this May 18, 2020
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PVince81
Copy link
Contributor Author

Fixes #186
Fixes #203
Fixes #183

I've enabled the Litmus props tests, they should pass now!

@PVince81
Copy link
Contributor Author

hmmm, a strange failure:


1) Scenario: without any share the shared-with-me page should be empty (attempt 2) # tests/acceptance/features/webUIFiles/fileDetails.feature:120
--

wondering if this is related to the Phoenix sidebar changes, but I don't see why it would fail with OCIS

@PVince81
Copy link
Contributor Author

test is passing locally... attempting a build restart...

@PVince81
Copy link
Contributor Author

okay, same failure. at least it's consistent...

Timed out while waiting for element <//nav[contains(@class, "oc-sidebar-nav")]/ul/li/a[contains(text(),"Shared with me")]> to be present for 20000 milliseconds. - expected "visible" but got: "not found" (20001ms)

@PVince81
Copy link
Contributor Author

quick attempt: I've now set the screen resolution explicitly to 1920x1080, just in case.

to me it seems like maybe during that test on Drone the left sidebar is closed and the action for opening it might be missing

@PVince81
Copy link
Contributor Author

hmm, I tested locally with 768x1024 but it still manages to open the sidebar, so it might be something else...

@PVince81
Copy link
Contributor Author

the failure also exists on an other PR: https://cloud.drone.io/owncloud/ocis-reva/340/3/10

so it's not related to the update

@PVince81
Copy link
Contributor Author

raised test PR owncloud/web#3471 to check if it was failing already on Phoenix master

@PVince81
Copy link
Contributor Author

tests pass on Phoenix master: owncloud/web#3471 but not sure if it's 100% the same thing

@individual-it can you help ?

@individual-it
Copy link
Member

It looks like we are not using the phoenix code from the phoenix repo but the code that is compiled into ocis, so we don't get the current phoenix. that is a mistake, @dpakach please fix that

@dpakach
Copy link
Contributor

dpakach commented May 19, 2020

@PVince81 The phoenix version should be fixed by #209
Please rebase after that gets merged.

@PVince81 PVince81 force-pushed the update-ocis-reva-props-goodness branch from b3138c5 to 6b4d985 Compare May 19, 2020 08:06
@PVince81
Copy link
Contributor Author

Rebased and removed the forced screen resolution which did not solve the issue anyway

@PVince81 PVince81 merged commit 0b68dda into master May 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the update-ocis-reva-props-goodness branch May 19, 2020 08:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants