Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Update reva to 20200710 #371

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Update reva to 20200710 #371

merged 1 commit into from
Jul 13, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jul 10, 2020

Brings in the reva items in the changelog.

This will include new test code and scenario changes matching cs3org/reva#966 from:
owncloud/core#37674 Remove admin auth error in log when running API acceptance tests
owncloud/core#37675 Add env var TEST_REVA

Which allows the latest core test scenarios to pass here.

464 scenarios (464 passed)
3359 steps (3359 passed)
6m5.92s (20.40Mb)

https://cloud.drone.io/owncloud/ocis-reva/662/2/6

@phil-davis phil-davis self-assigned this Jul 10, 2020
@phil-davis phil-davis changed the title Bump core commit for tests [Tests-Only] Bump core commit for tests Jul 10, 2020
@owncloud owncloud deleted a comment from update-docs bot Jul 10, 2020
@phil-davis phil-davis marked this pull request as ready for review July 10, 2020 14:36
@phil-davis
Copy link
Contributor Author

phil-davis commented Jul 10, 2020

https://cloud.drone.io/owncloud/ocis-reva/658/2/6

--- Failed scenarios:

    /srv/app/testrunner/tests/acceptance/features/apiShareUpdate/updateShare.feature:335
    /srv/app/testrunner/tests/acceptance/features/apiShareUpdate/updateShare.feature:336

442 scenarios (440 passed, 2 failed)
  Scenario Outline: API responds with a full set of parameters when owner changes the permission of a share # /srv/app/testrunner/tests/acceptance/features/apiShareUpdate/updateShare.feature:291
    Given using OCS API version "<ocs_api_version>"                                                         # FeatureContext::usingOcsApiVersion()
    And user "Brian" has been created with default attributes and without skeleton files                    # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And user "Alice" has created folder "/Alice-folder"                                                     # FeatureContext::userHasCreatedFolder()
    And user "Alice" has shared folder "/Alice-folder" with user "Brian" with permissions "read"            # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    When user "Alice" updates the last share using the sharing API with                                     # FeatureContext::userUpdatesTheLastShareWith()
      | permissions | all |
    Then the OCS status code should be "<ocs_status_code>"                                                  # OCSContext::theOCSStatusCodeShouldBe()
    And the OCS status message should be "OK"                                                               # OCSContext::theOCSStatusMessageShouldBe()
    And the HTTP status code should be "200"                                                                # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    Then the fields of the last response to user "Alice" sharing with user "Brian" should include           # FeatureContext::checkFieldsOfLastResponseToUser()
      | id                         | A_STRING             |
      | share_type                 | user                 |
      | uid_owner                  | %username%           |
      | displayname_owner          | %displayname%        |
      | permissions                | all                  |
      | stime                      | A_NUMBER             |
      | parent                     |                      |
      | expiration                 |                      |
      | token                      |                      |
      | uid_file_owner             | %username%           |
      | displayname_file_owner     | %displayname%        |
      | additional_info_owner      |                      |
      | additional_info_file_owner |                      |
      | state                      | 0                    |
      | item_type                  | folder               |
      | item_source                | A_STRING             |
      | path                       | /Alice-folder        |
      | mimetype                   | httpd/unix-directory |
      | storage_id                 | A_STRING             |
      | storage                    | 0                    |
      | file_source                | A_STRING             |
      | file_target                | /Alice-folder        |
      | share_with                 | %username%           |
      | share_with_displayname     | %displayname%        |
      | share_with_additional_info |                      |
      | mail_send                  | 0                    |
      | name                       |                      |
    And the fields of the last response should not include                                                  # FeatureContext::checkFieldsNotInResponse()
      | attributes |  |

    Examples:
      | ocs_api_version | ocs_status_code |
      | 1               | 100             |
        │ item_type has unexpected value ''
        │ 
        item_type doesn't have value 'folder'
        Failed asserting that false is true.
      | 2               | 200             |
        │ item_type has unexpected value ''
        │ 
        item_type doesn't have value 'folder'
        Failed asserting that false is true.

these fields in a share response are now being filled in by the latest cs3org/reva code. I guess ocis-reva needs to be updated with newer code from cs3org/reva

@phil-davis phil-davis changed the title [Tests-Only] Bump core commit for tests Update reva to 20200710 Jul 13, 2020
@phil-davis
Copy link
Contributor Author

I have updated reva to 20200710 and tests pass - great. Ready for review.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 0fe0286 into master Jul 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the bump-core-commit-20200710 branch July 13, 2020 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants