environment updates for the username userid split #420

butonic · 2020-07-31T20:48:21Z

We updated the owncloud storage driver in reva to properly look up users by userid or username using the userprovider instead of taking the path segment as is. This requires the user service address as well as changing the default layout to the userid instead of the username. The latter is not considered a stable and persistent identifier.

requires a replace of reva for the PR cs3org/reva#1033

PVince81 · 2020-08-12T09:13:57Z

"/srv/app/testrunner/tests/acceptance/features/apiWebdavUpload1/uploadFile.feature:63" is not supposed to run with OC-Storage, and yet it does here https://github.com/owncloud/core/blob/reva-tests/tests/acceptance/features/apiWebdavUpload1/uploadFile.feature#L63

@individual-it test setup issue ?

PVince81 · 2020-08-12T09:15:16Z

the test has these tags: @skipOnOcV10 @skipOnOcis-OC-Storage @issue-ocis-reva-265`
maybe missing @skipOnOcis or the exclusion files need update

phil-davis · 2020-08-12T09:20:42Z

There are no skipOnOcV10 test scenarios any more in core. owncloud/core#37773

I guess this PR needs a rebase to latest master here in ocis-reva

PVince81 · 2020-08-13T15:29:37Z

reva updated to get the sharing fixes from #439

PVince81 · 2020-08-13T15:36:53Z

merging blocked by unexpected failing tests:

apiOcisSpecific/apiShareManagementBasic-createShare.feature:116
apiOcisSpecific/apiShareManagementBasic-createShare.feature:117

not sure if these are legit failures or intended to skip ? @individual-it

phil-davis · 2020-08-13T15:45:36Z

Those are local test scenarios that (were) demonstrating a bug.
https://cloud.drone.io/owncloud/ocis-reva/897/2/7

  @issue-ocis-reva-372 @issue-ocis-reva-243
  Scenario Outline: sharing subfolder of already shared folder, GET result is correct                                      # /drone/src/tests/acceptance/features/apiOcisSpecific/apiShareManagementBasic-createShare.feature:88
    Given using OCS API version "<ocs_api_version>"                                                                        # FeatureContext::usingOcsApiVersion()
    And these users have been created with default attributes and without skeleton files:                                  # FeatureContext::theseUsersHaveBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
      | username |
      | Brian    |
      | Carol    |
      | David    |
      | Emily    |
    And user "Alice" has created folder "/folder1"                                                                         # FeatureContext::userHasCreatedFolder()
    And user "Alice" has shared folder "/folder1" with user "Brian"                                                        # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    And user "Alice" has shared folder "/folder1" with user "Carol"                                                        # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    And user "Alice" has created folder "/folder1/folder2"                                                                 # FeatureContext::userHasCreatedFolder()
    And user "Alice" has shared folder "/folder1/folder2" with user "David"                                                # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    And user "Alice" has shared folder "/folder1/folder2" with user "Emily"                                                # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    When user "Alice" sends HTTP method "GET" to OCS API endpoint "/apps/files_sharing/api/v1/shares"                      # OCSContext::userSendsToOcsApiEndpoint()
    Then the OCS status code should be "<ocs_status_code>"                                                                 # OCSContext::theOCSStatusCodeShouldBe()
    And the HTTP status code should be "<http_status_code>"                                                                # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And user "Alice" sends HTTP method "GET" to OCS API endpoint "/apps/files_sharing/api/v1/shares?path=/folder1/folder2" # OCSContext::userSendsToOcsApiEndpoint()
    And the response should contain 2 entries                                                                              # FeatureContext::checkingTheResponseEntriesCount()
    And folder "/folder1" should not be included as path in the response                                                   # FeatureContext::checkSharedFileAsPathNotInResponse()
    And folder "/folder2" should be included as path in the response                                                       # FeatureContext::checkSharedFileAsPathInResponse()

    Examples:
      | ocs_api_version | http_status_code | ocs_status_code |
      | 1               | 200              | 996             |
        OCS status code is not the expected value 996 got 100
        Failed asserting that two strings are equal.
        --- Expected
        +++ Actual
        @@ @@
        -'996'
        +'100'
      | 2               | 500              | 996             |
        OCS status code is not the expected value 996 got 200
        Failed asserting that two strings are equal.
        --- Expected
        +++ Actual
        @@ @@
        -'996'
        +'200'

It looks like the codes are better. So stuff has been fixed in cs3org/reva and now we are importing the fixed code from there.

I hope that there are "unexpected passes" in the Core-API tests - but they seem to have passed as they are. So there is no failing scenario from there that is now passing.

So maybe the local scenario here is improved but not going to fully pass every step yet.

For that, adjust the test scenario in this PR to expect the better status codes.

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

…e:88 to match cs3org/reva

ownclouders · 2020-08-13T16:14:44Z

Here is an overview of what got changed by this pull request:

Clones added
============
- pkg/flagset/storageoc.go  2
- pkg/command/storagehome.go  1
- pkg/flagset/storagehome.go  3
- pkg/flagset/storageeosdata.go  1
- pkg/command/storageocdata.go  2
- pkg/flagset/storagehomedata.go  4
- pkg/command/storageoc.go  1
- pkg/flagset/storageocdata.go  2
- pkg/command/storagehomedata.go  2
         

Clones removed
==============
+ pkg/flagset/storageroot.go  -2
+ pkg/flagset/storageeos.go  -1

See the complete overview on Codacy

phil-davis · 2020-08-13T16:21:51Z

I have adjusted the test scenario to the improved status codes, so that it now reads the same as in cs3org/reva.
CI should pass - someone can review, and IMO this can be merged.

kulmann · 2020-08-13T16:44:31Z

pkg/flagset/storagehome.go

+
+		&cli.StringFlag{
+			Name:        "users-url",
+			Value:       "localhost:9144",


I remember people complaining here, that a URL should always have http(s)://. Please adjust. ;-)

kulmann · 2020-08-13T16:44:55Z

pkg/flagset/storagehomedata.go

+
+		&cli.StringFlag{
+			Name:        "users-url",
+			Value:       "localhost:9144",


Please add http(s):// (see first comment)

kulmann · 2020-08-13T16:45:01Z

pkg/flagset/storageoc.go

+
+		&cli.StringFlag{
+			Name:        "users-url",
+			Value:       "localhost:9144",


Please add http(s):// (see first comment)

kulmann · 2020-08-13T16:45:11Z

pkg/flagset/storageocdata.go

+
+		&cli.StringFlag{
+			Name:        "users-url",
+			Value:       "localhost:9144",


Please add http(s):// (see first comment)

PVince81 · 2020-08-14T04:35:59Z

I started adjusting locally and saw that other unrelated URLs are also not prefixed. I'd rather not risk more side effects now and leave it be, unless @butonic thinks it is safe to adjust them all...

PVince81 · 2020-08-14T04:38:38Z

I've raised https://github.com/owncloud/ocis-reva/issues/440 for addressing the https thing

PVince81

👍

This was referenced Aug 3, 2020

Update deps 2020 07 22 owncloud/ocis#409

Merged

Download with signing key not working owncloud/ocis#436

Closed

butonic force-pushed the username-userid-split-adjustments branch 3 times, most recently from 2787e0b to 1f8f08c Compare August 10, 2020 13:01

PVince81 mentioned this pull request Aug 11, 2020

lookup user by id as well owncloud/ocis-proxy#85

Merged

3 tasks

butonic force-pushed the username-userid-split-adjustments branch 2 times, most recently from 4e85610 to 53a4180 Compare August 11, 2020 14:47

butonic mentioned this pull request Aug 12, 2020

With EOS storage backend, the new WebDAV API doesn't work on #409 owncloud/ocis#444

Closed

butonic and others added 5 commits August 13, 2020 21:37

environment updates for the username userid split

f905988

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

update reva to v1.0.1-0.20200810113514-38919badfcc7

f0ad60d

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

go mod tidy

38176a8

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

update ocis-reva with reva@master

d7978e0

Update reva to v1.1.1-0.20200813152025-baea1c67fb87

aec920b

phil-davis force-pushed the username-userid-split-adjustments branch 2 times, most recently from e35e0bb to 6911261 Compare August 13, 2020 16:03

Adjust expected results of apiShareManagementBasic-createShare.featur…

b1b712a

…e:88 to match cs3org/reva

phil-davis force-pushed the username-userid-split-adjustments branch from 6911261 to b1b712a Compare August 13, 2020 16:13

kulmann suggested changes Aug 13, 2020

View reviewed changes

PVince81 approved these changes Aug 14, 2020

View reviewed changes

PVince81 merged commit 6361bb5 into master Aug 14, 2020

PVince81 mentioned this pull request Aug 19, 2020

update reva to v1.1.1-0.20200819100654-dcbf0c8ea187 #447

Merged

phil-davis deleted the username-userid-split-adjustments branch August 27, 2020 11:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

environment updates for the username userid split #420

environment updates for the username userid split #420

butonic commented Jul 31, 2020

PVince81 commented Aug 12, 2020

PVince81 commented Aug 12, 2020

phil-davis commented Aug 12, 2020

PVince81 commented Aug 13, 2020

PVince81 commented Aug 13, 2020

phil-davis commented Aug 13, 2020

ownclouders commented Aug 13, 2020

phil-davis commented Aug 13, 2020 •

edited

Loading

kulmann Aug 13, 2020

kulmann Aug 13, 2020

kulmann Aug 13, 2020

kulmann Aug 13, 2020

PVince81 commented Aug 14, 2020

PVince81 commented Aug 14, 2020

PVince81 left a comment

environment updates for the username userid split #420

environment updates for the username userid split #420

Conversation

butonic commented Jul 31, 2020

PVince81 commented Aug 12, 2020

PVince81 commented Aug 12, 2020

phil-davis commented Aug 12, 2020

PVince81 commented Aug 13, 2020

PVince81 commented Aug 13, 2020

phil-davis commented Aug 13, 2020

ownclouders commented Aug 13, 2020

phil-davis commented Aug 13, 2020 • edited Loading

kulmann Aug 13, 2020

Choose a reason for hiding this comment

kulmann Aug 13, 2020

Choose a reason for hiding this comment

kulmann Aug 13, 2020

Choose a reason for hiding this comment

kulmann Aug 13, 2020

Choose a reason for hiding this comment

PVince81 commented Aug 14, 2020

PVince81 commented Aug 14, 2020

PVince81 left a comment

Choose a reason for hiding this comment

phil-davis commented Aug 13, 2020 •

edited

Loading